fix: remove buggy linting for eck-stack#22
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where the YAML auto-fixer (yamlfix) can produce invalid YAML for the Argo CD ECK stack Application, and updates the affected manifest formatting to a valid structure.
Changes:
- Fix
syncOptionsformatting in the ECK Argo CDApplicationmanifest to use a properly-indented block list. - Exclude
common/monitoring/eck-stack.yamlfrom the YAML auto-fix workflow to avoidyamlfixproducing invalid output for that file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
common/monitoring/eck-stack.yaml |
Rewrites syncOptions into a valid, properly-indented YAML list. |
.github/workflows/lint-yaml.yml |
Excludes the ECK stack manifest from yamlfix to prevent invalid rewrites during automated lint/fix runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ThanKarab
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.