fix: macOS font rendering + CI deprecation warning - #18
Merged
Conversation
…t on macOS -webkit-font-smoothing: antialiased disables subpixel antialiasing on macOS, causing pixel fonts (DotGothic16) to appear blurry on Retina displays. Changed to auto which uses the OS default rendering.
There was a problem hiding this comment.
Pull request overview
This PR applies two small maintenance fixes: it adjusts global font-smoothing defaults to improve macOS Retina rendering for the DotGothic16 pixel font, and updates the GitHub Pages artifact action to a newer major version to eliminate Node 20 deprecation warnings during CI deploys.
Changes:
- Updated
-webkit-font-smoothing/-moz-osx-font-smoothingfrom forced smoothing values toautoto allow platform defaults (restoring subpixel antialiasing behavior on macOS where applicable). - Upgraded
actions/upload-pages-artifactfromv3tov4in the GitHub Pages deploy workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/index.css |
Resets font-smoothing overrides to auto to improve macOS font rendering for the global app font. |
.github/workflows/deploy.yml |
Upgrades the Pages artifact upload action to v4 to address deprecation warnings in GitHub Actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes pushed directly to main, now tracked via PR.
Changes
Font smoothing: Changed
-webkit-font-smoothingfromantialiasedtoautoantialiaseddisables subpixel antialiasing on macOS, causing pixel fonts (DotGothic16) to appear blurry on Retina displaysCI: Upgraded
actions/upload-pages-artifactfrom v3 to v4