Repository navigation
feat(i18n): add Spanish - #344
Open
PedroFlores199 wants to merge 1 commit into
Open
PedroFlores199 wants to merge 1 commit into
PedroFlores199 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds an
escatalog (Spanish, Spain) and registers it in the language picker. It has all 439 keys ofen, with the same$Nslots and untouchedplaceholdersblocks._locales/es/messages.json: new catalog, 439 stringssrc/i18n/runtime.js: import,CATALOGSandLOCALE_NAMES("Español")docs/translating.md: Apple's Spanish name for the Passwords app and a row in the language tabletest-harness/automation/i18n.test.ts: Spanish checks fores/es-ES/es-419resolution,$Nslots,¡/¿punctuation, the unlock code wording, Apple's names and the 132-character description;frameError("Error: $1") is spelled the same as in English, so it joinsSAME_AS_ENTerminology follows Apple's Spanish UI: "Contraseñas de iCloud", "la app Contraseñas", "iCloud para Windows", "llaves de acceso" (passkeys), "código de verificación", "clave de configuración" (setup key). The pairing PIN is always "código de desbloqueo", never the verification code. "Login" is "inicio de sesión", as in Bitwarden's Spanish UI, and the copy uses the informal "tú".
Why
Refs #265: Spanish as a new interface language. A browser set to Spanish gets the English UI today.
How I checked it
pnpm typecheckpnpm testnode scripts/check-locales.tsandnode test-harness/automation/i18n.test.tspass with the new Spanish checks