Fix unique constraint violation when updating remap table #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #38 This could happen because we were keeping outdated entries in remap tables of work packages - the tuples (master_fid, wp_fid) would get added as needed, but they were never getting deleting when the corresponding features got deleted. As a result, users could get an error from SQLite about unique constraint violation when inserting to the remap table because the master_fid already existed there from some previous runs.
MarcelGeo
approved these changes
Aug 19, 2025
MarcelGeo
left a comment
MarcelGeo
left a comment
There was a problem hiding this comment.
Nice, as we discussed that in person - LGTM.
PeterPetrik
reviewed
Aug 23, 2025
|
|
||
| - name: Kyle_duplicate | ||
| value: 4 | ||
| mergin-project: martin/farms-Kyle-duplicate |
Contributor
There was a problem hiding this comment.
doens't look like good location for test files in Martin workspace :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
This could happen because we were keeping outdated entries in remap tables of work packages - the tuples (master_fid, wp_fid) would get added as needed, but they were never getting deleting when the corresponding features got deleted. As a result, users could get an error from SQLite about unique constraint violation when inserting to the remap table because the master_fid already existed there from some previous runs.