Skip to content

fix(config): clear the item bins before rebuilding them on reload #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icemansparks merged 1 commit into from
Aug 25, 2026
Merged

fix(config): clear the item bins before rebuilding them on reload #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions src/AuctionHouseBotConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2667,6 +2667,47 @@ void AHBConfig::InitializeFromSql(std::set<uint32> botsIds)

void AHBConfig::InitializeBins()
{
//
// Start from empty containers. Initialize() runs this again on every
// ".reload config" without going through Reset(), so without this the bins
// keep items that the reloaded configuration or blacklist just excluded,
// and the vectors grow by a full copy of themselves on each reload.
//

GreyTradeGoodsBin.clear();
WhiteTradeGoodsBin.clear();
GreenTradeGoodsBin.clear();
BlueTradeGoodsBin.clear();
PurpleTradeGoodsBin.clear();
OrangeTradeGoodsBin.clear();
YellowTradeGoodsBin.clear();

GreyItemsBin.clear();
WhiteItemsBin.clear();
GreenItemsBin.clear();
BlueItemsBin.clear();
PurpleItemsBin.clear();
OrangeItemsBin.clear();
YellowItemsBin.clear();

GreyTradeGoodsVec.clear();
WhiteTradeGoodsVec.clear();
GreenTradeGoodsVec.clear();
BlueTradeGoodsVec.clear();
PurpleTradeGoodsVec.clear();
OrangeTradeGoodsVec.clear();
YellowTradeGoodsVec.clear();

GreyItemsVec.clear();
WhiteItemsVec.clear();
GreenItemsVec.clear();
BlueItemsVec.clear();
PurpleItemsVec.clear();
OrangeItemsVec.clear();
YellowItemsVec.clear();

SellableItems.clear();

//
// Exclude items depending on the configuration; whatever passes all the tests is put in the lists.
//
Expand Down
Loading