feat: scaffold CMake project + DESIGN.md (source of truth for Codex)#1
Merged
Conversation
Lays down the C++23 / LLVM-only scaffold that Codex will implement against. The architecture mirrors merlion-node-exporter-rs one-to-one so a scrape diff between the two binaries reduces to numeric / label- order noise. - CMakeLists.txt — C++23, LLVM clang fatal-errors on Apple Clang, matches the toolchain pattern from merlion-tsdb-cpp - cmake/ToolchainLLVM.cmake — pins Homebrew LLVM - src/main.cpp + src/placeholder.cpp — entry point + structural stub - include/merlion_node_exporter/version.hpp.in — generated header - tests/placeholder_test.cpp — first GoogleTest case (will be replaced when real collectors land) - docs/DESIGN.md — source-of-truth design doc covering Metric model, encoder, registry, HTTP server, collector contract, CLI, and the 15-collector MVP plan. Disagreement between this doc and code is a bug; update the doc before introducing a non-trivial design choice. - .github/workflows/ci.yml — Linux + macOS LLVM build/test matrix Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First substantive PR. Lays down the C++23 / LLVM-only scaffold for the C++ sibling of `merlion-node-exporter-rs`, plus the source-of-truth design document that Codex implements against.
What's in this PR
Scaffold
`docs/DESIGN.md`
Source of truth for the C++ implementation. Covers the Metric model (hand-rolled, no client-library dep), text-0.0.4 encoder, registry, HTTP server, collector contract, CLI, and the 15-collector MVP plan. Disagreement between this doc and the code is a bug — update the doc before introducing a non-trivial design choice.
The doc mirrors `merlion-node-exporter-rs` one-to-one so a scrape diff between the two binaries reduces to numeric / label-order noise.
What's next
Per DESIGN.md §7, the MVP set is: cpu, diskstats, netdev, filesystem, stat, vmstat, netstat, sockstat, pressure, hwmon, thermal_zone, time, textfile. One PR per collector, mirroring the matching `-rs` PR.