Mc 4102 improve performance of inserting diagram in google doc plugin and add analytics #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… google docs plugin
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the Google Docs plugin, focusing on enhanced user experience, better error handling, analytics tracking, and modernization of the codebase. Key updates include improved loading states for dialogs, refactoring image insertion/update flows to use
BroadcastChannel, the addition of a robust analytics module, and UI/UX enhancements.User Experience Improvements:
src/client/create-diagram-dialog/components/create-diagram-dialog.tsx,src/client/create-diagram-dialog/index.html,src/client/edit-diagram-dialog/components/edit-diagram-dialog.tsx,src/client/edit-diagram-dialog/index.html,src/client/select-diagram-dialog/components/select-diagram-dialog.tsx) [1] [2] [3] [4] [5] [6] [7]Image Handling Refactor:
BroadcastChannelfor communication with the sidebar, improving performance and reliability. (src/client/create-diagram-dialog/components/create-diagram-dialog.tsx,src/client/edit-diagram-dialog/components/edit-diagram-dialog.tsx) [1] [2]Analytics and Tracking:
src/analytics/analytics.ts,src/analytics/httpClient.ts,src/client/hooks/useAuth.ts) [1] [2] [3] [4]UI/UX Enhancements:
src/client/components/button.module.css)src/client/components/toast.tsx)Build and Environment Updates:
package.jsonto usenpxfor clasp commands and bumped the version to 1.2.0 for better developer experience. (package.json).clasp.jsonwith new script and parent IDs. (.clasp.json)These changes collectively improve the plugin's reliability, maintainability, and user experience.