Conversation
|
This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review fix (#1748): the overview claimed a misconfigured cache fails open. Invalid configuration fails closed — config validation and resolve_kv_disk_config return an error (fixed mode without a budget, non-IEC/zero sizes, relative directories, minimum-free below 1 GiB), so the node refuses to start rather than silently falling back. Only a valid configuration whose store cannot open, reaches low space, or cannot admit a write falls back to cold prefill. Narrowed the overview and the troubleshooting table accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
f0924b9 to
1414471
Compare
Document disk-cache modes, configuration precedence, budgets, observability, maintenance, failure handling, and recovery.
Explain the default cache experience, supported controls, durable disk opt-in, backend scope, and experimental CacheGen boundary.
ab46cc9 to
3c18a33
Compare
danielwinterw
left a comment
There was a problem hiding this comment.
Approving.
I spot-checked the operator guide's numbers against the code on this branch and they hold: DEFAULT_KV_DISK_MINIMUM_FREE_MIB = 16 * 1024 and MIN_KV_DISK_MINIMUM_FREE_MIB = 1024 in mesh-llm-config/src/model.rs, AUTO_MAX_BUDGET_BYTES = 64 GiB in kv_disk_config.rs, and EVICTION_LOW_WATER_PERCENT = 85 in skippy-cache/src/l3.rs. The fail-closed-config / fail-open-runtime split is the distinction operators actually get wrong, and putting it in bold above the fold is the right call. The legacy SKIPPY_L3_* section is the most useful part of the page — field-level-fallback-only, SKIPPY_L3_BUDGET_BYTES=0 no longer meaning unbounded, and the implied-fixed-mode behaviour are all things that would otherwise be discovered by surprise. Restart-vs-live-apply table and the troubleshooting matrix are concrete rather than generic. All checks pass.
One nice-to-have: this is based on scama/skippy-cachegen-rocm-mask (#1816), which puts it five deep in the stack, but the content documents the L3 tier from #1632/#1736 and I did not find anything in it that depends on CacheGen. Rebasing onto #1736 — or onto main once that lands — would let the guide ship without waiting on a 13k-line codec change. Worth doing given how much of this page is aimed at people about to turn the tier on for the first time.
… into erlich/kv-disk-operator-guide
… into erlich/kv-disk-operator-guide
… into erlich/kv-disk-operator-guide
|
Website guide validation is green at exact head Local checks:
GitHub CI: 18 passed, 10 expected skips, 0 failures. The guide documents the default automatic in-memory prefix cache, model-fit TOML controls, disk-cache config/environment/CLI overrides, lifecycle commands, OpenAI cache fields, CPU/Metal/CUDA/ROCm scope, and CacheGen's experimental status. |
|
Superseded by consolidated integration PR #1838. The focused branch and review history remain available; further production wiring continues from the consolidated head. |
The KV-cache stack did not have one user-facing entry point: operators had to infer resident-cache behavior, exact K/V representation, durable disk controls, and the experimental CacheGen boundary from implementation notes. This PR adds that website guide and keeps the detailed disk operator runbook.
What users get
cached_tokensreporting.Validation
just website-buildnpm run buildnpm run check:clinpm run test:cli-explorergit diff --checkBase: #1816, the consolidated CacheGen stack. This supersedes the earlier disk-only review shape of #1748 without creating a duplicate documentation PR.