Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Manifest v4 can identify each segment independently, but L3 still stamped every segment as
raw/1. That left the native runtime KV control arm implicit and allowed a fixed-size cut to mix native KV bytes with recurrent state.Result
native-kv-page/1segment identity and persist F32, F16, Q8_0, and Q4_0 runtime exports byte-for-byte, with no storage transcode.L3Locationso the server validates the native page descriptor and located prefix before reading segment bytes; recheck metadata after load to close the locate/load race.Advances #1652. This is stacked on #1752.
Validation
Exact candidate commit:
9be4e30158a34612c818aeef4d47b2a045c62ff5cargo test -p skippy-cache --lib— 170 passed, 0 failed, 2 ignoredcargo test -p skippy-server --lib— 708 passed, 0 failed, 3 ignoredcargo clippy -p skippy-cache -p skippy-server --all-targets -- -D warningscargo fmt --all -- --checkgit diff --checkMatched realistic-segment stopwatch on the same Apple Silicon host and debug toolchain:
cargo test -p skippy-cache --lib l3::tests::eviction_cost_at_realistic_segment_counts -- --ignored --nocaptureaa533c0d45e1b8af025ee9af9887de68a7f02baf: build 2,021 ms; budget enforcement 1,375 ms9be4e30158a34612c818aeef4d47b2a045c62ff5: build 2,113 ms; budget enforcement 1,396 msThis slice does not change admission, eviction, prefix reuse, or resident capacity, so the competitive c64/c128/c256 policy matrix is unchanged.