Skip to content

fix(ci): render llama canary agent output as text - #1867

Merged
i386 merged 1 commit into
mainfrom
scama/readable-canary-agent-logs
Sep 14, 2026
Merged

i386 merged 1 commit into
mainfrom
scama/readable-canary-agent-logs

Conversation

@i386

@i386 i386 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Original problem

The changed-pin llama canary asked Goose for stream-json and copied the event stream directly into the live Actions log. Since Goose emits assistant thinking and text as small streaming messages, a short sentence appeared as many full JSON objects and was difficult to follow while the canary ran.

Diagnostics

The harness had no structured-output consumer: scripts/llama-canary-agent-repair.sh sent --output-format stream-json to Goose and piped that stdout directly to tee. Goose already provides a native text renderer for assistant text, thinking, tool calls, tool results, and errors.

Fix

Use Goose's native text output mode for the canary agent session. The existing live output and retained agent.log now receive Goose-formatted human-readable output, while session naming, resume behavior, provider/model selection, credentials, timeouts, verification gates, and publication controls remain unchanged.

The harness contract test now fixes the readable output mode, and the CI inventory documents the behavior.

Validation

  • just ci-validate — 1,461 tests passed, 9 skipped; Actionlint and all repository consistency gates passed
  • python3 -m unittest scripts.tests.test_llama_canary_agent_repair_contract — 20 passed
  • just ci-shellcheck scripts/llama-canary-agent-repair.sh
  • No UI changes; visual evidence does not apply

Summary by CodeRabbit

  • Documentation

    • Updated canary verification guidance to clarify split certification, complete-battery requirements, and independent validation for changed and unchanged pins.
  • Bug Fixes

    • Improved automated repair session output by using a consistent text format, making results easier to read and process.
  • Tests

    • Updated validation coverage to confirm the revised repair-session output format.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 798e25ca-1fff-44e0-a59d-e3967c531f3b

📥 Commits

Reviewing files that changed from the base of the PR and between c573119 and 6f323bd.

📒 Files selected for processing (3)
  • ci/ci.md
  • scripts/llama-canary-agent-repair.sh
  • scripts/tests/test_llama_canary_agent_repair_contract.py

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Canary output contract

Layer / File(s) Summary
Agent output and certification contract
scripts/llama-canary-agent-repair.sh, scripts/tests/test_llama_canary_agent_repair_contract.py, ci/ci.md
The wrapper now requests text output from goose. The contract test expects text. The CI documentation describes the split certification roster checks.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 6f323

The wrapper now produces readable live and retained logs without changing repair status handling or verification gates, so the change is mergeable.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: rendering Llama canary agent output as text in CI.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch scama/readable-canary-agent-logs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@i386
i386 enabled auto-merge (squash) September 14, 2026 09:17
@i386
i386 merged commit 950e905 into main Sep 14, 2026
72 of 82 checks passed
@i386
i386 deleted the scama/readable-canary-agent-logs branch September 14, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant