fix: widen bounded package shutdown checks - #29
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.76.1 recovery reached structured client readiness in every native package lane, but two independent hosted runners exceeded the existing 10-second SIGINT shutdown window. The identical Homebrew formula passed minutes earlier, and all other package/image rows passed, which isolates this to runner-load timing rather than package corruption.
Use a consistent 30-second bound for the shared package/image smoke and Homebrew formula. The smoke still sends SIGINT once, requires a clean zero exit, and force-cleans processes that exceed the bound.
Validation:
node --experimental-strip-types scripts/image-matrix.ts validateshellcheck scripts/client-readiness-smoke.shgit diff --check