Repository navigation
missing GUI elements - #749
Merged
Merged
Conversation
The suppressed count and the per-cell chip counters reached the control socket and the export but no window. The radio tab now carries the IRQ suppressed count beside the masks that cause it, reading "not counted" for a chip that predates it, and the spurious detections beside busy time. The sweep results gain suppressed and busy columns, averaged over the seeds whose chips counted them and drawn as a dash where none did: two firmwares that flood identically differ there and nowhere else.
… radio tab names them
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chip counters Tom added (#745, #746, and the chip model work in MeshBench/virtual-sx1262#2) reached the control socket and
experiment.export, but no window showed them. This puts them where somebody comparing firmware would look.What changes
Node window, Radio tab
Bench view, sweep results
irq_suppressed, as a cost (fewer is green).Verbs
experiment.resultsarm summaries carryirq_suppressedandbusy_ms, absent where nothing counted. Its description says so;docs/verbs.jsonanddocs/verb-reference.mdare regenerated.Pictures
radioshot_test.go(new) and achip-counterscase insweepshot_test.godraw these from real numbers out of a 15-cell scotland-strict run (MeshCore 1.16.0, 1.17.0, 1.17.1 at virtual-sx1262 v1.3.3):Verification
go testforinternal/app/session/experiment,internal/app/state,internal/ui/workbench(control audit included),internal/ui/workbench/nodeviewandinternal: pass.gofmt,go vet: clean.tools/lint-ratchet.shwith golangci-lint v2.12.2: holds.verbdoc.py --check: current. Verb manifest test: passes.Manual: a MeshBench/docs PR follows with the same pictures.