Repository navigation
Conversation
WiX writes the MSI through Windows' msi.dll and builds nowhere else, and wixl builds no dialogs. So the job splits: the Linux windows job stages both trees and makes the icon, dialog bitmaps and product code (windows-msi.sh); windows-msi builds both installers with WiX on windows-latest and puts ALLUSERS back to 2 through Windows Installer's own API (windows-msi.ps1); windows-msi-verify reads them back with msitools on Linux, and only what passes is offered to the release. meshbench.wxs and verify-msi.sh return to the WiX versions from #534. For #508.
MajorUpgrade writes WIX_UPGRADE_DETECTED and WIX_DOWNGRADE_DETECTED; the check looked only for the WiX 3 names, and the first MSI WiX built in the pipeline failed it with both rows present.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #508.
WiX can only write an MSI on Windows (it needs
msi.dll), and wixl builds no dialogs. That is why the WiX installer from #534 was reverted in #578. This PR splits the job so each part runs where it can:windows(lab-2204, as now) builds and zips both trees.packaging/windows-msi.shnow only prepares: the icon (icotool), the dialog bitmaps (Pillow), the installer's note, andmsi.env(MSI version, product and upgrade codes). It uploads both staged trees asmsi-stage.windows-msi(windows-latest, free for this public repo) installs WiX 5.0.2 and the UI extension.packaging/windows-msi.ps1runswix build, putsALLUSERSback to 2 through Windows Installer's own database API (WiX 4+ will not author it), and counts the harvested files.windows-msi-verify(lab-2204) reads both MSIs back with msitools viaverify-msi.sh. Only what passes is uploaded asmeshbench-windows-msi, and the release now downloadsmeshbench-*artifacts only.meshbench.wxs,verify-msi.shand the install docs go back to the #534 versions. Two fixes came out of the first runs:verify-msi.shlooked for the WiX 3 upgrade property names; WiX 5 writesWIX_UPGRADE_DETECTEDandWIX_DOWNGRADE_DETECTED.Dispatch runs on this branch (
release: false): the last one, 40156447430, is green in every job. Both MSIs pass every check:SetARPINSTALLLOCATION;ALLUSERS2;Not done here: an interactive install on a real Windows machine. It's worth one double-click to see the pages before this goes into a release. The workflow is otherwise unchanged for tags.