Repository navigation
Conversation
The engine sends kind 0x0A, [failure][frame...], for a frame this node's receiver locked onto and could not trust, and the device hands it to vsx_deliver_frame_failed. The symbol is bound only if the chip model has it, so a model older than 1.3.2 loads as before and the kind is skipped.
Collaborator
Author
|
Closing for now. Today's native bridge hangs up on a message kind it does not know, so MeshBench/meshbench#757 now sends |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QEMU half of MeshBench/meshbench#757.
The engine now sends kind
0x0A,[failure][frame...], for a frame this node locked onto and lost. The device hands it tovsx_deliver_frame_failed, so the chip raisesHeaderErralone for a header it could not read, orRxDonebesideCrcErrfor a payload it could not.vsx_deliver_frame_failedis bound optionally: it arrived in virtual-sx1262 1.3.2, and refusing to load an older chip model over an entry point only this kind needs would break boards that work today. With an older model the kind is skipped, which is what happened to it before.Checked:
hw/ssi/sx1262.ccompiles with this tree's own flags fromcompile_commands.json(-fsyntax-only, warnings as errors). Not booted on a board yet.