Repository navigation
house rules: VirtualSX1262.h may reach 550 lines - #6
Merged
Merged
Conversation
The command-set record took the header past the 500 limit, and main has failed the check since. The file is granted the length it has and no more, so it can shrink but not grow, and the exception sits in CLAUDE.md beside the rule it bends. Moving the recorded-only commands into their own type is what retires it.
A13xB0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/VirtualSX1262.hhas been 512 lines since #2, over the 500 hard limit, sohouse rulesfails onmainand on every PR (#5 among them).This gives that one file a fixed ceiling of 550 lines: room for the next few fields without reopening the rule, and still a ceiling. Every other file keeps 500. The exception is written into
CLAUDE.mdbeside the rule, with what retires it: moving the recorded-only command set (the two "rest of the command set" sections) into its own type.Checked locally: the loop as written passes on this tree, and the workflow parses.