Skip to content

Live advert endpoints can retain the previous node name #164

Description

@n30nex

Summary

A valid advert that renames a node can still broadcast the previous name in packetObservation.observation.resolvedSource.

handlePacket resolves the advert's exact source before handlePayloadTypeSideEffects calls UpsertNode. The packet summary and nodeUpdate can carry the new name while the packet event's preferred resolved source still carries the old one. A first advert can also miss exact live resolution until the node exists. Stored reads now resolve current names after #163.

I found this while investigating the reported stale repeater names. I will add signed-advert regression coverage and resolve live endpoints after the advert side effects, preserving invalid-signature handling, source/destination direction and duplicate observation behavior. No API/schema change is planned.

The current TXT_MSG parser already follows the protocol's destination/source byte order; it should not be reversed to work around ambiguous display names.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions