feat(ws): allow subdomain wildcards in allowed origins - #177
Merged
Merged
Conversation
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #170.
websocket.allowed_originsonly took exact origins, which doesn't work when a site serves its pages from lots of subdomains that keep growing. This lets you writehttps://*.example.cominstead of listing each one.The websocket library already matches these patterns, so the only real change is in
validateOrigin. The one new form it accepts is*.as the whole leftmost label with at least two labels after it. Anything else with*,?,[,]or\is still rejected (https://*,*.com,a*.example.com,x.*.example.com, and so on).Matching behaviour:
https://*.example.commatchessub.example.comanda.b.example.com, case-insensitivelyexample.com, so list that separately if you need itDefault-off. Configs without a wildcard behave the same as before. CORS is untouched.
Tests: config validation cases for the accepted and rejected forms, plus real handshake cases in
TestAllowedOrigins(subdomains get through, while apex, lookalike hosts, wrong scheme and wrong port get 403). No API changes, so swagger is unchanged.