Skip to content

fix(ingest): preserve valid RFC3339 packet timestamps - #184

Merged
MrAlders0n merged 1 commit into
MeshCore-Beacon:devfrom
n30nex:codex/beacon-timestamp-offsets
Sep 30, 2026
Merged

MrAlders0n merged 1 commit into
MeshCore-Beacon:devfrom
n30nex:codex/beacon-timestamp-offsets

Conversation

@n30nex

@n30nex n30nex commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Valid whole-second, millisecond and nanosecond packet timestamps with numeric UTC offsets could be replaced by receive time. Use Go's RFC3339 parser plus the existing timezone-less UTC fallback. Preserve malformed-input fallback and the 30-minute skew clamp; no schema, API or dependency change.

Closes #181. Independent on accepted dev. The ingest regression failed first and now covers Z/+00:00/-04:00/+05:30, four precisions, legacy timezone-less input and invalid/future/stale timestamps. The live one-minute sample had zero parser fallbacks; skew and malformed-IATA warnings remain.

Parent db30c9b573357990c41166292e7cf42785c92cc4, head c39df3043931dbe37d51a73d15f050a1c61d1a3b. Focused diff.

Published-head CI and the complete combined native Pi/PostgreSQL suite pass. The Pi runs server a35cba1d / web e1133ab5, retaining every review candidate. Windows/Pi web build/lint and all 940 tests pass. The isolated 3,200-input/504-scope replay preserved expected data/events with zero fixture drops; this is not a universal production losslessness claim. Validation, exact heads and recovery / running source.

Maintainers retain merge/release control; AI-assisted work continues under the contributor's standing authorization.

@n30nex
n30nex requested a review from 446564 as a code owner September 29, 2026 22:38
@n30nex

n30nex commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

@MrAlders0n / Claude: addressed at c39df304.

Ready for review: this fixes #181 without changing delivery/deduplication or the skew policy. The failing-format reproduction, full local/native suites and exact-head CI pass. The candidate is included on the Pi preview.

Published-head CI and the complete combined native Pi/PostgreSQL suite pass. The Pi runs server a35cba1d / web e1133ab5, retaining every review candidate. Windows/Pi web build/lint and all 940 tests pass. The isolated 3,200-input/504-scope replay preserved expected data/events with zero fixture drops; this is not a universal production losslessness claim. Validation, exact heads and recovery / running source.

Please take another look when convenient; no upstream merges were performed.

@MrAlders0n
MrAlders0n requested review from MrAlders0n and removed request for 446564 September 30, 2026 11:24
@MrAlders0n
MrAlders0n merged commit 89a376c into MeshCore-Beacon:dev Sep 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept RFC3339 packet timestamps with numeric offsets and no fractional seconds

2 participants