fix: follow up on last week's merges (#55-#101) - #102
Merged
Merged
Conversation
Bugs: clear compare params on tab change, recover channel live messages after a 429, observer copy link keeps only region params, route table no longer navigates on region change with nothing selected, map borders memo on data identity, live overview can't resurrect a failed query, French relative times, no language write on first visit, 0/0 node locations hidden outside the map, path/signal stats use the shared retry rule. i18n: node/packet/mesh/observer strings that were still hardcoded after #62. Cleanup: formatUtc, ACTION_BUTTON_CLASS, observer-stats, useWindowedStats, observer-id; observer pages use StatCard/Card/Field/Segmented/SearchBar/SelectDropdown; one details chrome on the stats tabs; comment and translations-guide trims; localStorage stub for Node 26 in the test setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from a review of the 13 PRs merged into
devlast week (#55–#101).Bugs
compareWith/UntilandcompareA/B/Since/Until(only on a real tab change) — the Analytics › Compare tab no longer shows a spurious "invalid link" alert after using the observer comparison.useMapBordersDatamemos on data identity instead ofdataUpdatedAt.beacon-language=enbefore any user choice.retry: false.i18n: "View on map", the no-resolution tooltip (PacketEndpoints + PathData), the Mesh tab labels, the observer battery/noise legends, the node "last heard" tooltips.
Cleanup:
formatUtc,ACTION_BUTTON_CLASS,observer-stats,useWindowedStats,observer-id; observer pages useStatCard/Card/Field/Segmented/SearchBar/SelectDropdown(no moremin-h-11); one<details>chrome across the stats tabs; comment anddocs/translations.mdtrims; in-memorylocalStorageintests/setup.tsfor Node 26.Build, lint and 1014 tests pass.