Repository navigation
Fix theme-aware chart colour selection - #147
Merged
MrAlders0n merged 3 commits intoOct 10, 2026
Merged
Conversation
Keeps every theme's own series colours and swaps in a generated hue only where a slot duplicates an earlier one (Phosphor/Radar primary = green, Amber/Earth green = secondary). Multi-colour views use the deduplicated series slots; single-series charts keep their theme tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Replaces the fixed chart-series token order and RGB blends with a categorical
palette derived from the active theme. Some themes reuse semantic colours — for
example, Phosphor and Radar use the same value for
primaryandgreen— whichmade unrelated chart series identical or nearly indistinguishable.
primaryfor neutral single-series charts, generated colours for categories and comparisons, and primary-derived ramps for sequential data.Type of change
Checklist
npm run buildpasses (the real typecheck)npm run lintpassesnpm testpassesTesting notes
npm test— 1206 passednpm run buildnpm run lint— 0 errors, 2 pre-existing warningsReviewers should pay particular attention to multi-series charts in the
Phosphor, Radar, Amber, and Earth themes, which previously contained duplicate
semantic colours.