Skip to content

fix(packets): prevent route and scope overlap - #92

Open
n30nex wants to merge 14 commits into
MeshCore-Beacon:devfrom
n30nex:codex/beacon-packet-scope-layout
Open

n30nex wants to merge 14 commits into
MeshCore-Beacon:devfrom
n30nex:codex/beacon-packet-scope-layout

Conversation

@n30nex

@n30nex n30nex commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Scoped transport packets let TRANSPORT_FLOOD/DIRECT text and the scope badge overflow an 80px route track into the observation count. The route track is now 128px with a separate line for the scope, while each desktop row remains 37px tall. Full names remain available in the row text and title; long scopes are contained on phone cards too. Scope spelling/case is preserved.

Closes #90. Follows #89; exact parent 037858b, head 6b68849. Focused diff.

The browser regression failed on the deployed row: text reached x357.5 and the badge x397 beyond the cell's x340 edge, crossing the observation column at x352. The repaired layout passes desktop and 768px geometry checks, short/mixed-case/long/no-scope cases, keyboard selection, and 390px phone overflow checks. Windows build/lint and all 935 tests pass; existing build warnings remain. Native Pi build/lint and all 935 tests also pass. Initial validation used dfeb277 on the Pi preview; the same real BB2F2752 row and seven other scoped rows pass the public geometry check, including 37px row height. English desktop and French 390px phone checks pass, both inputs and LIVE are verified, and all 18 assets plus both source archives match the changelog/source. Frontend publication restarted no services. Exact-head CI passes; repository CodeQL is skipped. No dependency or API change. The tested preview keeps every prior review candidate and rollback.

Current integration (28 September): the queue is refreshed onto accepted web dev 17f48fb9. Parent 037858b4646349c4599d9067fb8f42ad9d1a34a3, published head 6b6884951a3dac01b592dfec83f0191879c5696c. Focused diff. Build/lint/tests pass for this refreshed tree and actual-head build CI passes (repository CodeQL skipped). The full web composition 6b688495 is now deployed on Pi server 2ed2e031, retaining every candidate. Its native build/lint and all 935 tests pass; all 18 public assets and both source archives match. Web assets are byte-identical to the previously geometry-tested build; fresh English desktop/French phone and Public-message packet inspection pass. Current evidence and recovery. Earlier feature-specific validation above is historical. No feature behavior changed in this base refresh.

@n30nex

n30nex commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

@MrAlders0n could you and Claude review this packet layout fix? It follows #89 with a focused parent comparison in the description. The overlap reproduced in the supplied screenshot is fixed on the Pi preview, including the same BB2F2752 row. All 935 tests pass on Windows and the Pi; exact-head CI, desktop/phone geometry, English/French and public source/asset checks pass. The route cell keeps a 37px row while showing the route and exact-case scope separately. Previous review candidates and rollback remain available.

@MrAlders0n

Copy link
Copy Markdown
Member

LGTM. Row height still matches the virtualizer's 37px estimate. A small test that asserts truncation would be nice, since the renamed test doesn't check anything new.

@MrAlders0n

Copy link
Copy Markdown
Member

Thanks for the ordering in docs #5. Since this lands as one squash of #92, please fix each item on its own branch and restack. Must-fix before merge: #75 nested button, #79 modal stacking + Observer pill, #80 comments, #81 stale anchor + tick, #83 observation pick, #85 route link wipe, #87 split or justify the visit mode, #89 maxPages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent transport route labels from overlapping packet scope badges

2 participants