Skip to content

Convert jules_pftparm to a duplicate namelist; one namelist per PFT - #132

Draft
Maggie (maggiehendry) wants to merge 20 commits into
MetOffice:mainfrom
maggiehendry:115-convert-jules_pftparm-to-a-duplicate-namelist
Draft

Convert jules_pftparm to a duplicate namelist; one namelist per PFT#132
Maggie (maggiehendry) wants to merge 20 commits into
MetOffice:mainfrom
maggiehendry:115-convert-jules_pftparm-to-a-duplicate-namelist

Conversation

@maggiehendry

@maggiehendry Maggie (maggiehendry) commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

See issue #136 for details.

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings
  • If editing rose-meta/jules-shared then have you supplied a linked UM and LFRic Apps PR?

Testing

  • I have tested this change locally, using the JULES rose-stem suite
  • If shared files have been modified, I have run the UM and LFRic Apps rose
    stem suites
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system
    tests, unit tests, etc.)

trac.log

Test Suite Results - jules - jules-test-115-convert-jules_pftparm-to-a-duplicate-namelist/run1

Suite Information

Item Value
Suite Name jules-test-115-convert-jules_pftparm-to-a-duplicate-namelist/run1
Suite User margaret.hendry
Workflow Start 2026-09-11T10:32:32
Groups Run all
Dependency Reference Main Like
jules maggiehendry/jules@test-115-convert-jules_pftparm-to-a-duplicate-namelist False
SimSys_Scripts MetOffice/SimSys_Scripts@2026.07.1 True

Task Information

✅ succeeded tasks - 676

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

Approvals

Please request all relevant approvals. See the CodeOwners.txt file for section
owners.

Technical

  • JULES Code Owner
  • OpenMP
  • River Routing
  • Rose Stem
  • Rose Metadata
  • Upgrade Macros

Scientific

  • Surface
  • Hydrology
  • Vegetation
  • Veg3 RED Demography
  • Biogechemistry
  • Biogenic fluxes
  • Fire
  • Lakes
  • Evaluation
  • Imogen

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@maggiehendry
Standalone read jules_pftparm namelist moved to its own routine.
78dd1a7
@maggiehendry
Limited functionality of duplicate namelist for jules_pftparm imple…
a2ffe28 
…mented

* Only 5 PFTs like LFRic apps currently
@maggiehendry
Corrections to metadata for duplicate namelist compatibility.
33dd3ed
@maggiehendry
Mapping from namelist instance to tile number from surface configurat…
932af02 
…ion written as a function.
@maggiehendry
pft_name_io created from jules_surface_types so generic.
821672e
@maggiehendry
Manual corrections to allow upgrade macro to work.
845f2ea
@maggiehendry
Upgrade macro will now run on entire Rose stem including usr_types.…
d1a1fb1 
… However, the code won't run as I haven't updated it to recognise the added PFTs.
@maggiehendry
Map PFT name to tile number updated for all currently defined PFTs ap…
970e49f 
…art from `usr_types`.
@maggiehendry
Map namelist instance to tile number extended to usr_type and relat…
dc486a4 
…ed changes to upgrade macro.
@maggiehendry
UM reading and initialisation routines for jules_pftparm now read dup…
873474c 
…licate namelists.
@maggiehendry
- Upgrade macro changes from UM applied to JULES as equally relevant.
c4c24c1 
* Macro split into two initially to investigate the um script hang, but is useful to see what corrections have had to be implemented before splitting into indiviual namelists.
- How rivers dealt with changed as it didn't validate against the metadata.
- UM metadata amendments removed for pftparm.
- c_z0h_z0m now broadcast to fix UM bug.
@maggiehendry
Reorder upgrade macro consistent with UM macro.
16c9a06
@maggiehendry
Bugs fixed for LFRic apps build.
d036146
@maggiehendry
Error in jules-lfric corrected.
d537229
@maggiehendry
Merge branch 'stable' into 115-convert-jules_pftparm-to-a-duplicate-n…
9079d03 
…amelist
@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Jul 13, 2026
@maggiehendry Maggie (maggiehendry) changed the title 115 convert jules pftparm to a duplicate namelist Convert jules_pftparm to a duplicate namelist; one namelist per PFT Jul 13, 2026
@maggiehendry Maggie (maggiehendry) linked an issue Aug 4, 2026 that may be closed by this pull request
Convert jules_pftparm to a duplicate namelist #115
Open
@maggiehendry Maggie (maggiehendry) mentioned this pull request Sep 11, 2026
Open
43 tasks
@maggiehendry Maggie (maggiehendry) added this to the Autumn 2026 milestone Sep 11, 2026
@maggiehendry Maggie (maggiehendry) mentioned this pull request Sep 11, 2026
Draft
28 tasks
@github-actions github-actions Bot added cla-modified The CLA has been modified as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

⚠️ Hello Maggie (@maggiehendry)!

Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR.

Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james-bruten-mo James Bruten (james-bruten-mo) Awaiting requested review from james-bruten-mo james-bruten-mo will be requested when the pull request is marked ready for review james-bruten-mo is a code owner
@GiorgiaLine Giorgia (GiorgiaLine) Awaiting requested review from GiorgiaLine GiorgiaLine will be requested when the pull request is marked ready for review GiorgiaLine is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@maggiehendry Maggie (maggiehendry)

Labels

cla-modified The CLA has been modified as part of this PR - added by GA

Projects

None yet

Milestone

Autumn 2026

Development

Successfully merging this pull request may close these issues.

Convert jules_pftparm to a duplicate namelist

2 participants

@maggiehendry @mo-ssd-bot