Skip to content

fix l bgc heat #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eleanor Burke (eleanorgb) wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix l bgc heat #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1cd7caa
adding dim_cslayer as dimension
eleanorgb Aug 17, 2026
26378cb
l_bgc_heat can be used in um and for one layer soil carbon
eleanorgb Aug 28, 2026
f78d828
adding cla
eleanorgb Aug 28, 2026
1b3a974
Merge branch 'main' into 126---fix-l_bgc_heat
eleanorgb Aug 28, 2026
f7a0f7a
fixing resp_s_soilt call
eleanorgb Aug 28, 2026
fa42d1c
Merge remote-tracking branch 'upstream/main' into 126---fix-l_bgc_heat
eleanorgb Sep 15, 2026
83fd7a4
better merging into main
eleanorgb Sep 15, 2026
069ca9a
updating metadata in jules-shared
eleanorgb Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
| yaswant | Yaswant Pradhan | Met Office | 2026-06-30 |
| doucla | Douglas Clark | UKCEH | 2026-07-03 |
| james-bruten-mo | James Bruten | Met Office | 2026-07-09 |
| eleanorgb | Eleanor Burke | Met Office | 2026-08-24 |
| maggiehendry | Maggie Hendry | Met Office | 2026-08-21 |
| DanCopsey | Dan Copsey | Met Office | 2026-08-24 |
| Pierre-siddall | Pierre Siddall | Met Office | 2026-08-26 |
1 change: 0 additions & 1 deletion rose-meta/jules-shared/jules-model-environment/HEAD/rose-meta.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ trigger=namelist:jules_deposition=l_deposition_from_ukca: 1;
=namelist:jules_soil=l_bedrock: 0;
=namelist:jules_soil=l_tile_soil: 0;
=namelist:jules_soil_biogeochem=l_label_frac_cs: 0;
=namelist:jules_soil_biogeochem=l_bgc_heat: 0;
=namelist:jules_surface=l_vary_z0m_soil: 1;
=namelist:jules_surface=formdrag: 1;
=namelist:jules_surface=i_modiscopt: 1;
Expand Down
3 changes: 0 additions & 3 deletions rose-meta/jules-shared/jules-soil-biogeochem/HEAD/rose-meta.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,6 @@ url=https://metoffice.github.io/jules/latest/namelists/jules_soil_biogeochem.nml
[namelist:jules_soil_biogeochem=l_bgc_heat]
compulsory=true
description=Switch for release of biogeochemical heat into the soil.
=Not available to the UM.
fail-if=this == '.true.' and namelist:jules_model_environment=l_jules_parent == 1; #Biogenic heating scheme is not available to the UM
sort-key=c1
trigger=namelist:jules_soil_biogeochem=heat_of_respiration: .true.;
type=logical
Expand Down Expand Up @@ -229,7 +227,6 @@ sort-key=c
url=https://metoffice.github.io/jules/latest/namelists/jules_soil_biogeochem.nml.html#JULES_SOIL_BIOGEOCHEM::l_q10
value-titles=Q10 temperature function,Clark et al. (2011) temperature function
values=.true.,.false.
warn-if=this == '.false.' and namelist:jules_soil_biogeochem=l_bgc_heat == '.true.'
widget[rose-config-edit]=cylc8_compat.ComboBoxValueWidget

[namelist:jules_soil_biogeochem=l_soil_resp_lev2]
Expand Down
14 changes: 0 additions & 14 deletions src/control/shared/jules_soil_biogeochem_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,20 +333,6 @@ SUBROUTINE check_jules_soil_biogeochem()
'the layered soil temperature calculation (l_ch4_tlayered)' )
END IF

! Check if l_q10=T to use l_bgc_heat
IF ( .NOT. l_q10 .AND. l_bgc_heat ) THEN
CALL ereport( TRIM(RoutineName), warningstatus, &
'To use the biogenic heating of soil carbon decomposition' // &
'you must use l_q10=.true. and l_bgc_heat=.true.' )
END IF

! Check if l_layeredC=T to use l_bgc_heat

@maggiehendry Maggie (maggiehendry) Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right in thinking that these changes allow l_bgc_heat to be used either with l_layeredC=.true. or l_layeredC=.false.

@eleanorgb Eleanor Burke (eleanorgb) Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct

IF ( .NOT. l_layeredc .AND. l_bgc_heat ) THEN
CALL ereport( TRIM(RoutineName), errorstatus, &
'To use the biogenic heating of soil carbon decomposition' // &
'you must use l_layeredc=.true. and l_bgc_heat=.true.' )
END IF

! Check if l_bgc_heat = T, heat_of_respiration is 3.7e09
IF ( l_bgc_heat ) THEN
IF ( ABS( heat_of_respiration - rmdi ) < EPSILON(1.0) ) THEN
Expand Down
12 changes: 1 addition & 11 deletions src/control/um/check_unavailable_options_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ SUBROUTINE check_unavailable_options()
USE jules_urban_mod, ONLY: l_urban_empirical
USE jules_rivers_mod, ONLY: l_riv_overbank, l_rivers, i_river_vn, &
rivers_um_trip, rivers_rfm
USE jules_soil_biogeochem_mod, ONLY: l_ch4_microbe, l_label_frac_cs, &
l_bgc_heat
USE jules_soil_biogeochem_mod, ONLY: l_ch4_microbe, l_label_frac_cs
USE jules_soil_mod, ONLY: l_tile_soil, l_bedrock
USE jules_surface_types_mod, ONLY: ncpft
USE jules_water_resources_mod, ONLY: l_water_resources
Expand Down Expand Up @@ -71,15 +70,6 @@ SUBROUTINE check_unavailable_options()
END IF
END IF

! jules_soil_biogeochem_mod
IF ( l_bgc_heat ) THEN
error_sum = error_sum + 1
WRITE(jules_message,'(I0,A,L1)') error_sum, &
": Biogenic heating scheme is only available to standalone JULES. " // &
"l_bgc_heat = ", l_bgc_heat
CALL jules_print(RoutineName, jules_message, level = PrNorm)
END IF

! jules_soil_biogeochem_mod
IF ( l_ch4_microbe ) THEN
error_sum = error_sum + 1
Expand Down
4 changes: 2 additions & 2 deletions src/science/soil/hydrol_jls_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,7 @@ SUBROUTINE hydrol ( &
sathh_soilt(:,m,:), smcl_soilt(:,m,:), snowdepth_surft, &
surf_ht_flux_ld, smvcst_soilt(:,m,:), w_flux_soilt(:,m,:), &
sthf_soilt(:,m,:), sthu_soilt(:,m,:), sthu_irr_soilt(:,m,:), &
t_soil_soilt(:,m,:), tsoil_deep_gb, dim_cs1, resp_s_soilt )
t_soil_soilt(:,m,:), tsoil_deep_gb, dim_cs1, resp_s_soilt(:,m,:,:) )
ELSE
! Surface and soil tiles map directly on to each other.
DO m = 1, nsoilt
Expand All @@ -1139,7 +1139,7 @@ SUBROUTINE hydrol ( &
sathh_soilt(:,m,:), smcl_soilt(:,m,:), snowdepth_surft, &
snow_soil_htf(:,n), smvcst_soilt(:,m,:), w_flux_soilt(:,m,:), &
sthf_soilt(:,m,:), sthu_soilt(:,m,:), sthu_irr_soilt(:,m,:), &
t_soil_soilt(:,m,:), tsoil_deep_gb, dim_cs1, resp_s_soilt )
t_soil_soilt(:,m,:), tsoil_deep_gb, dim_cs1, resp_s_soilt(:,m,:,:) )
END DO
END IF

Expand Down
7 changes: 4 additions & 3 deletions src/science/soil/soil_htc_jls_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ SUBROUTINE soil_htc ( npnts, nshyd, nsurft, soil_pts, timestep, soil_index, &
USE jules_soil_mod, ONLY: facur, gamma_t, mmax, tacur, l_bedrock, &
ns_deep
USE jules_soil_biogeochem_mod, ONLY: heat_of_respiration, l_bgc_heat
USE ancil_info, ONLY: dim_cslayer
USE jules_surface_mod, ONLY: l_flake_model
USE jules_surface_types_mod, ONLY: lake
USE jules_irrig_mod, ONLY: l_irrig_dmd
Expand Down Expand Up @@ -104,7 +105,7 @@ SUBROUTINE soil_htc ( npnts, nshyd, nsurft, soil_pts, timestep, soil_index, &
! Volumetric soil moisture concentration at saturation (m3 H2O/m3 soil).
w_flux(npnts,0:nshyd), &
! The fluxes of water between layers (kg/m2/s).
resp_s_soilt(npnts,nshyd,dim_cs1)
resp_s_soilt(npnts,dim_cslayer,dim_cs1)
! Soil respiration in pools (kg C/m2/s) in each layer
! The fluxes of water between layers (kg/m2/s).

Expand Down Expand Up @@ -384,7 +385,7 @@ SUBROUTINE soil_htc ( npnts, nshyd, nsurft, soil_pts, timestep, soil_index, &
!$OMP w_flux, dhadv_dtsl0, dhadv_dtsl1, dhadv_dtsl2, v_sat, &
!$OMP tiny_0, smcl, small_value, work1, smclsat, bexp, tmax, sathh, &
!$OMP dhsl0, timestep, dhsl, resp_s_soilt, l_bgc_heat, dim_cs1, &
!$OMP heat_of_respiration)
!$OMP dim_cslayer, heat_of_respiration)

! Blocking is needed as the nshyd dimension has a spatial
! dependence (n +/-1). Blocking enables parallelising over the
Expand Down Expand Up @@ -490,7 +491,7 @@ SUBROUTINE soil_htc ( npnts, nshyd, nsurft, soil_pts, timestep, soil_index, &
IF (l_bgc_heat) THEN
!$OMP DO SCHEDULE(STATIC)
DO j = 1, soil_pts
DO n = 1, nshyd
DO n = 1, dim_cslayer
!DIR$ IVDEP
!CDIR NODEP
i = soil_index(j)
Expand Down
Loading