Update LfricApps to allow for kernel API changes in Core Science components (Tranche 1) - #654
Open
Ricky Wong (mo-rickywong) wants to merge 68 commits into
Open
Ricky Wong (mo-rickywong) wants to merge 68 commits into
Ricky Wong (mo-rickywong) wants to merge 68 commits into
Conversation
Ricky Wong (mo-rickywong)
marked this pull request as ready for review
September 4, 2026 08:10
Ricky Wong (mo-rickywong)
requested review from
a team,
DrTVockerodtMO,
Alex Brown (atb1995),
Hacka Fett (christophermaynard),
cjohnson-pi,
iboutle,
James Kent (jameskent-metoffice),
mo-cjsmith,
Lottie Turner (mo-lottieturner),
thomasmelvin and
Thomas Bendall (tommbendall)
as code owners
September 4, 2026 08:10
Ricky Wong (mo-rickywong)
requested review from
Andrew Coughtrie (andrewcoughtrie)
and removed request for
a team
September 4, 2026 08:10
DanStoneMO
approved these changes
Sep 4, 2026
DanStoneMO
left a comment
Contributor
There was a problem hiding this comment.
Tested JEDI with this and it ran fine, no linked PR needed for it
thomasmelvin
approved these changes
Sep 11, 2026
thomasmelvin
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, one trivial comment for consideration
28 tasks
mo-cjsmith
reviewed
Sep 15, 2026
mo-cjsmith
reviewed
Sep 15, 2026
mo-cjsmith
reviewed
Sep 15, 2026
mo-cjsmith
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: Steve Mullerworth (@stevemullerworth)
Update Apps repository as impacted by changes in lfric_core PR MetOffice/lfric_core#440. This is a result of changes to the api of kernels in an initial tranche of updates in lfric_core.
This PR updates applications in LFRic apps by:
Passing of
config_typeto algorithms that call affected kernels.Extraction of the required namelist variables to be passed by argument.
Where applicable, passing of
mesh_idis replaced with passing the mesh object itself, withconfig, mesharguments at the beginning of argument lists.Note: geology/topology is not extracted from
base_mesh_config, it is queried from the mesh object.base_meshwas only intended for use by top-level application driver code, the intention is to phase out parts ofbase_meshand delegate that functionality to individual applications. (see blocking PRS)Linked PRs
This PR is blocked
base_mesh_configgeology/topologyenumerations #757Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - AppsCleanFeigners_1/run1
Suite Information
Task Information
✅ succeeded tasks - 1218
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review