Changes to Apps repository impacted by refactoring of init_chi_transforms

[Ricky Wong (mo-rickywong)]

PR Summary

Sci/Tech Reviewer: Thomas Bendall (@tommbendall)
Code Reviewer: Mike Hobson (@mike-hobson)

Changes to apps as a result of Linked Core PR. The lfric core change removes the need to call init_chi_transforms for all tests. Only on spherical geometry meshes which have have rotation of stretching applied. As such, the majority of this change is deleting calls from unit tests.

Linked PRs

• linked Refactor code implementing initial chi transform with respect to North Pole and Schmit stretching lfric_core#460

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Apps rose-stem suite
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - AppsRefactorChiTrans/run1

Suite Information

Item	Value
Suite Name	AppsRefactorChiTrans/run1
Suite User	ricky.wong
Workflow Start	2026-09-03T07:04:02
Groups Run	developer

Dependency	Reference	Main Like
casim	MetOffice/casim@2026.07.1	True
jules	MetOffice/jules@2026.07.1	True
lfric_apps	mo-rickywong/lfric_apps@AppsRefactorChiTrans	False
lfric_core	mo-rickywong/lfric_core@RefactorChiTrans	True
moci	MetOffice/moci@2026.07.1	True
SimSys_Scripts	MetOffice/SimSys_Scripts@77a5166	True
socrates	MetOffice/socrates@2026.07.1	True
socrates-spectral	MetOffice/socrates-spectral@2026.07.1	True
ukca	MetOffice/ukca@9fc2b6d	True

Task Information

✅ succeeded tasks - 1218

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the HPC Optimisation Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[DanStoneMO]

I've tested this with JEDI and am experiencing some test failures on saber_covstats tests, example output

Currently looking into this and will probably raise a linked JEDI PR for this down the line

[thomasmelvin]

LGTM

[Thomas Bendall (tommbendall)]

This PR essentially removes a lot of calls to init_chi_transforms and final_chi_transforms from unit-tests, that are now optional given the changes in the linked Core branch.

I see no issues so am happy for this to pass science review.

[mo-cjsmith]

All fine with initialisation.