Skip to content

CoMorph KGO-breaking refactoring #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaelWhitall wants to merge 36 commits into
base: main
Choose a base branch
from
Open

CoMorph KGO-breaking refactoring #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
58792ea
Copied-in the whole comorph directory from the UM branch vn14.2_comor…
MichaelWhitall Aug 14, 2026
a9111d5
Set new variables in comorph_um_namelist_mod to default values for now.
MichaelWhitall Aug 14, 2026
3148523
Added accidentally missed min_cmr, max_cmr to use statement.
MichaelWhitall Aug 14, 2026
73daf6a
Fixed typo in comment.
MichaelWhitall Aug 19, 2026
315459e
Sync with the UM branch vn14.2_comorph_refact2: delete redundant fixe…
MichaelWhitall Aug 26, 2026
8a6be4d
First go at moving existing comorph namelist entries into their own n…
MichaelWhitall Aug 26, 2026
f5cf9dc
Fixed syntax error in upgrade macro.
MichaelWhitall Aug 26, 2026
fca1403
Compile failed with comorph namelist entries in their own comorph blo…
MichaelWhitall Aug 26, 2026
16a39a9
Amend the upgrade macro code that adds namelist:comorph to handle the…
MichaelWhitall Aug 27, 2026
98d4088
Attempt to correct the regex to account for whitespace.
MichaelWhitall Aug 27, 2026
41b853d
Another attempt to fix the regex (don't include the preceding ' ='…
MichaelWhitall Aug 27, 2026
9a2956c
Remove comorph namelist entries from the main convection namelist in …
MichaelWhitall Aug 27, 2026
ac21e87
Fiddle with the macro regex again; namelist:comorph needs to be in br…
MichaelWhitall Aug 27, 2026
2554e06
Simplified the regex; don't bother matching the preceding whitespace,…
MichaelWhitall Aug 27, 2026
be2d8c6
Sync with the UM branch vn14.2_comorph_dev.
MichaelWhitall Aug 28, 2026
8c1ac05
Sync with the UM branch vn14.2_comorph_refact2 (moved parcel_combine …
MichaelWhitall Aug 28, 2026
68fc4aa
Imported the rest of the existing UM comorph namelist entries into th…
MichaelWhitall Aug 31, 2026
74b2c05
Minor code-style tweak.
MichaelWhitall Aug 31, 2026
2d6c593
Add temporary hack to preserve KGO after migrating comorph settings t…
MichaelWhitall Sep 2, 2026
a616ebc
Sync with the UM branch vn14.2_comorph_refact2: moved setting of entr…
MichaelWhitall Sep 2, 2026
7a374cb
Added explicit precision conversion for real namelist variables, and …
MichaelWhitall Sep 3, 2026
f4b5877
Further changes to sync with the comorph_dev branch: (a) Numerous min…
MichaelWhitall Sep 7, 2026
75ea14a
Further improvements to comments in core_combine (sci/tech review req…
MichaelWhitall Sep 7, 2026
9ed21c6
Improved comments in autoconversion to clarify what cond1 and cond2 a…
MichaelWhitall Sep 7, 2026
cc06bb0
Refactored set_par_cloudfrac and related code to account for the poss…
MichaelWhitall Sep 9, 2026
a05e34c
Sync with the UM branch vn14.2_comorph_refact2: Added the missing uni…
MichaelWhitall Sep 11, 2026
b0e2153
Rename file in separate commit to preserve history before we modify it.
MichaelWhitall Sep 11, 2026
4d06e03
Copied-in the comorph directory from the UM branch vn14.2_comorph_ref…
MichaelWhitall Sep 11, 2026
b407f94
Copied-in required meta-data / namelist changes.
MichaelWhitall Sep 11, 2026
81b2e26
Changed precision of par_radius_knob to default (had only been set to…
MichaelWhitall Sep 11, 2026
4ec850d
Moved min_radius_fac and turb_len_fac to the genesis section of the c…
MichaelWhitall Sep 11, 2026
869b7c7
Sync with the UM branch vn14.2_comorph_refact3: delete stray trailing…
MichaelWhitall Sep 11, 2026
c25a8ea
Merge-in same version of main has has been merged into comorph_refact2.
MichaelWhitall Sep 11, 2026
3a8744d
Changed tag number in the upgrade macro to be the PR number rather th…
MichaelWhitall Sep 11, 2026
d644a10
Sync with vn3.2_comorph_refact3.
MichaelWhitall Sep 11, 2026
7aaae39
Updated the KGO checksums for all comorph rose-stem apps (all changed…
MichaelWhitall Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions applications/adjoint_tests/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,8 @@ stochastic_physics='none',
surface='none',
/
&convection
dx_ref=50000.0,
l_cvdiag_ctop_qmax=.false.,
qlmin=4.0e-4,
resdep_precipramp=.false.,
/
&cosp
l_cosp=.false.,
Expand Down
2 changes: 0 additions & 2 deletions applications/jedi_lfric_tests/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@ stochastic_physics='none',
surface='none',
/
&convection
dx_ref=50000.0,
l_cvdiag_ctop_qmax=.false.,
qlmin=4.0e-4,
resdep_precipramp=.false.,
/
&cosp
l_cosp=.false.,
Expand Down
2 changes: 0 additions & 2 deletions applications/jedi_lfric_tests/example_id_tlm_tests/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,8 @@ stochastic_physics='none',
surface='none',
/
&convection
dx_ref=50000.0,
l_cvdiag_ctop_qmax=.false.,
qlmin=4.0e-4,
resdep_precipramp=.false.,
/
&cosp
l_cosp=.false.,
Expand Down
2 changes: 0 additions & 2 deletions applications/jedi_lfric_tests/example_tlm_forecast_tl/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,8 @@ stochastic_physics='none',
surface='none',
/
&convection
dx_ref=50000.0,
l_cvdiag_ctop_qmax=.false.,
qlmin=4.0e-4,
resdep_precipramp=.false.,
/
&cosp
l_cosp=.false.,
Expand Down
2 changes: 0 additions & 2 deletions applications/jedi_lfric_tests/example_tlm_tests/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,8 @@ stochastic_physics='none',
surface='none',
/
&convection
dx_ref=50000.0,
l_cvdiag_ctop_qmax=.false.,
qlmin=4.0e-4,
resdep_precipramp=.false.,
/
&cosp
l_cosp=.false.,
Expand Down
2 changes: 0 additions & 2 deletions applications/ngarch/example/configuration_bl.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,8 @@ stochastic_physics='none',
surface='jules',
/
&convection
dx_ref=50000.0,
l_cvdiag_ctop_qmax=.false.,
qlmin=4.0e-4,
resdep_precipramp=.false.,
/
&cosp
l_cosp=.false.,
Expand Down
2 changes: 0 additions & 2 deletions applications/ngarch/example/configuration_casim.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,12 @@ chem_scheme='none',
&convection
cape_timescale=1800.0,
cv_scheme='gregory_rowntree',
dx_ref=50000.0,
efrac=1.0,
l_cvdiag_ctop_qmax=.false.,
number_of_convection_substeps=2,
orig_mdet_fac=1.0,
prog_ent_min=0.5,
qlmin=4.0e-4,
resdep_precipramp=.false.,
/
&cosp
l_cosp=.false.,
Expand Down
Loading