Skip to content

WIP: only use wallet_sessionChanged to establish connection if not already… #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiexi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: only use wallet_sessionChanged to establish connection if not already… #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions packages/connect-evm/src/connect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,23 +786,16 @@ export class MetamaskConnectEVM {
if (hexPermittedChainIds.length === 0) {
this.#onDisconnect();
} else {
let initialAccounts: Address[] = [];
if (this.#core.status === 'connected') {
const ethAccountsResponse =
await this.#core.transport.sendEip1193Message({
method: 'eth_accounts',
params: [],
});
initialAccounts = ethAccountsResponse.result as Address[];
} else {
initialAccounts = getEthAccounts(this.#sessionScopes);
if (this.#status === 'connected') {
return;
}

const accounts: Address[] = getEthAccounts(this.#sessionScopes);
const chainId = await this.#getSelectedChainId(hexPermittedChainIds);

this.#onConnect({
chainId,
accounts: initialAccounts,
accounts,
});
}
}
Expand Down Expand Up @@ -861,8 +854,6 @@ export class MetamaskConnectEVM {
};

if (this.#status === 'connected') {
this.#onChainChanged(chainId);
this.#onAccountsChanged(accounts);
return;
}

Expand Down
Loading