fix: prefer MMDS exact matches over intermediate component-library paths - #114
Draft
AndyMBridges wants to merge 1 commit into
Draft
fix: prefer MMDS exact matches over intermediate component-library paths#114AndyMBridges wants to merge 1 commit into
AndyMBridges wants to merge 1 commit into
Conversation
Deprecation messages sometimes point at in-repo components-temp first even when the same component already exists in @MetaMask/design-system-*. Check exact MMDS names before those intermediate hints so Skeleton (and similar cases) map to the real MMDS package. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@metamask/design-system-*name matches before intermediatecomponent-library/components-tempdeprecation hints in the config mapperSkeletonto@metamask/design-system-react-native(was incorrectlyComponentsTemp)ModalHeader,ModalContent, andFormTextFieldto@metamask/design-system-reactfor the same reasonWhy
Legacy deprecation messages sometimes point at in-repo stepping-stone paths even when MMDS already ships the component. That left dashboard “MMDS replacement” blank for components like mobile
Skeletondespite the package existing.Test plan
node -e/ unit check: mappingSkeletonwith a components-temp deprecation message andreactNative: ['Skeleton']returns@metamask/design-system-react-nativeyarn sync-config:skip-updatekeeps the corrected replacements (does not regress tocomponent-library)Skeleton→ MMDSSkeletonMade with Cursor