feat(storybook-rn): add page template and perps example stories - #1408
Draft
georgewrmarshall wants to merge 4 commits into
Draft
feat(storybook-rn): add page template and perps example stories#1408georgewrmarshall wants to merge 4 commits into
georgewrmarshall wants to merge 4 commits into
Conversation
- Remove single-value node-version matrices from lint-build-test and chromatic workflows; they added matrix scheduling overhead for zero parallelism benefit. Set cache-node-modules to true unconditionally. - Extract yarn test:scripts into its own one-shot job so it no longer runs once per workspace package in the test matrix. - Remove action-checkout-and-setup from the label-check workflow; the github-script action receives the full PR payload via context and needs no local checkout. - Run analyse-code in parallel with check-workflows instead of waiting for it to complete first; the security scanner has no dependency on workflow validation.
Adds four Storybook React Native example stories to apps/storybook-react-native/stories/: - FullScreenList — HeaderStandard + scrollable list (3 variants: Default/Settings, MultiAction/Networks, RootScreen/Notifications) - PerpsMarketList — ListItem market rows, SegmentedControl top movers, SensitiveText privacy masking via valueProps/subvalueProps isHidden - PerpsOrderForm — HeaderSubpage + KeyValueRow Input/Summary variants, BannerAlert service interruption, SelectButton order type - PerpsMarketStats — FilterButtonGroup category pills, KeyValueColumn 2x2 grid, Tag in SectionHeader title slot, BannerAlert low liquidity All stories use descriptionProps/valueProps/subvalueProps for styling (isHidden-capable after DSYS-936 / PR #1406) rather than manual SensitiveText wrappers in string slots. Jira: DSYS-937, DSYS-938
Contributor
📖 Storybook LinksCompare the preview for this pull request with the latest Storybooks from the 🔀 Pull Request Preview
🌳 Main Branch (Latest)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four Storybook React Native example stories to
apps/storybook-react-native/stories/based on a full header/title pattern audit of MetaMask Mobile. These serve as copy-paste references for the ~150 screens being migrated to MMDS components.Stories added
FullScreenList.stories.tsxExamples/Page Templates/Full Screen ListHeaderStandard,ListItem,SectionHeader,SectionDividerPerpsMarketList.stories.tsxExamples/Perps Market ListListItem,SegmentedControl,FilterButton,SectionHeader,SensitiveTextLengthviavaluePropsPerpsMarketStats.stories.tsxExamples/Perps Market StatsFilterButtonGroup,KeyValueColumn,TaginSectionHeadertitle,BannerAlertPerpsOrderForm.stories.tsxExamples/Perps Order FormHeaderSubpage,KeyValueRow.Input,KeyValueRow.Summary,SelectButton,BannerAlertFullScreenList variants
onBack+ singleendButtonIconProps(help), 3 sections, section dividersendButtonIconProps(search + add), active network indicatoronCloseonly (no back),subtitleslot, modal-stack root patternPatterns demonstrated
descriptionProps/valueProps/subvaluePropsfor colour andisHiddenmasking (DSYS-936 / PR feat: Add isHidden support to RN Content, TitleHub, and KeyValueRow #1406) — no manual<SensitiveText>wrappers in string slotsincludesTopInseton allHeaderStandardinstancesKeyValueRow.InputvsKeyValueRow.SummarydistinctionTagas ReactNode insideSectionHeadertitleFilterButtonGroupvsSegmentedControluse casesRelated issues
Jira: DSYS-937, DSYS-938
Test plan
yarn storybook:ios— openExamples/Page Templates/Full Screen List, confirm 3 variants renderExamples/Perps Market List— confirm gainers/losers toggle, position rows, watchlist add buttonsExamples/Perps Order Form— tap order type selector, confirm limit price row appearsExamples/Perps Market Stats— confirm category pills, 2×2 stat grids, low-liquidity banneryarn lintpasses (Prettier + ESLint)Note
Low Risk
Changes are documentation-style stories and CI plumbing only; no production app or auth/data paths.
Overview
Adds four React Native Storybook example screens under
Examples/as migration references: Full Screen List (settings, multi-action header, root/close-only variants), Perps Market List, Perps Market Stats, and Perps Order Form. They demonstrateHeaderStandard/HeaderSubpage, list layouts,KeyValueRowinput vs summary, filters, banners, and balance masking via list item props.CI workflow tweaks in the same PR: drop redundant Node 24.x matrices where unused; always enable node_modules caching on prepare; run
yarn test:scriptsin a dedicated test-scripts job instead of each package test matrix job; stop checking out the repo for the DO-NOT-MERGE label job; let analyse-code run without waiting on check-workflows.Reviewed by Cursor Bugbot for commit 17f7bdd. Bugbot is set up for automated code reviews on this repo. Configure here.