docs(dsrn): ListItem performance audit (React parity decision) - #1434
Draft
georgewrmarshall wants to merge 2 commits into
Draft
docs(dsrn): ListItem performance audit (React parity decision)#1434georgewrmarshall wants to merge 2 commits into
georgewrmarshall wants to merge 2 commits into
Conversation
Capture DevTools nesting findings vs ActionListItem and options for React parity without necessarily copying BoxRow/BoxColumn/Content internals. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
📖 Storybook LinksCompare the preview for this pull request with the latest Storybooks from the 🔀 Pull Request Preview
🌳 Main Branch (Latest)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a markdown performance/architecture audit for RN
ListItem(and itsContent/BoxRow/BoxColumnstack) based on Storybook + React DevTools nesting comparison againstActionListItem.Motivation: before React parity (DSYS-1041 → BoxRow, DSYS-1042 → BoxColumn, DSYS-1043 → Content, DSYS-713 → ListItem), decide whether web should copy the RN composition stack or ship a flatter implementation with the same consumer API.
The doc recommends shared public props + flatter React implementation, and treating
BoxRow/BoxColumnas optional helpers rather than required internals ofContent.Related issues
Fixes:
Related: DSYS-1041, DSYS-1042, DSYS-1043, DSYS-713 (parity queue)
Manual testing steps
packages/design-system-react-native/src/components/ListItem/PERFORMANCE_AUDIT.mdListItem/End AccessoryvsActionListItem/End Accessoryin React DevTools Components tabScreenshots/Recordings
Before
N/A (docs only)
After
N/A (docs only) — evidence described from DevTools trees captured during audit
Pre-merge author checklist
Pre-merge reviewer checklist
Made with Cursor