Fix: Add HTTP status checks in AuthModal #2601
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing HTTP status checks in authentication flow cause crashes when APIs return error status codes (401, 403, 500).
Solution
Added
response.okchecks before parsing JSON in both fetch calls:Changes
response.json()callsBefore:
After:
Impact:
✅ Prevents authentication crashes
✅ Proper error handling
✅ Better user experience
Fixes #2600
Note
Strengthens error handling in auth and JSON-RPC data fetching paths.
AuthModal.tsx, checkprojectsResponse.okanduksUserRawResp.okbeforeresponse.json(); throw descriptive errors on non-OK to avoid crashes and bad session storage.plugin-json-rpc.ts, updatefetchDatato validateresponse.okand return{ error: Error }on non-OK; catch now normalizes to anErrorinstance instead of a boolean flag.Written by Cursor Bugbot for commit 473fd59. This will update automatically on new commits. Configure here.