Skip to content

Conversation

@sirtimid
Copy link
Contributor

@sirtimid sirtimid commented Jan 12, 2026

Summary

  • Update @metamask/eslint-config from 14.0.0 to 15.0.0
  • Update @metamask/eslint-config-vitest from 1.0.0 to 15.0.0
  • Add JSDoc rules to eslint.config.mjs to enforce documentation standards
  • Fix JSDoc compliance issues across all packages (missing @param descriptions, missing @returns declarations)
  • Update test coverage thresholds based on actual coverage

Test plan

  • yarn lint passes with no errors
  • yarn build succeeds for all packages
  • yarn test passes with updated coverage thresholds

🤖 Generated with Claude Code


Note

Modernizes linting and documentation standards across the monorepo.

  • Upgrade @metamask/eslint-config* to v15 and update related dev deps repo-wide
  • Add jsdoc/require-jsdoc rule (with test/config exceptions) and keep explicit TS return types; disable JSDoc in select build/test files
  • Add/expand JSDoc comments for classes/functions throughout kernel, streams, logger, and other packages; remove unnecessary lint disables
  • Bump runtime deps where needed (e.g., @metamask/utils to ^11.9.0, @metamask/rpc-errors to ^7.0.3, @metamask/snaps-utils to ^11.7.1), and update yarn.lock
  • Adjust Vitest coverage thresholds to match current coverage

Written by Cursor Bugbot for commit ee06644. This will update automatically on new commits. Configure here.

sirtimid and others added 2 commits January 12, 2026 20:17
Update MetaMask packages to latest versions:
- @metamask/eslint-config: 14.0.0 → 15.0.0
- @metamask/eslint-config-nodejs: 14.0.0 → 15.0.0
- @metamask/eslint-config-typescript: 14.0.0 → 15.0.0
- @metamask/eslint-config-vitest: 1.0.0 → 15.0.0
- @metamask/auto-changelog: 5.0.1 → 5.3.0
- @metamask/utils: 11.4.2 → 11.9.0
- @metamask/snaps-utils: 11.6.1 → 11.7.1

Update eslint.config.mjs to configure JSDoc rules:
- Require JSDoc for functions, methods, and classes in TypeScript
- Disable JSDoc requirement for test files and config files

Add missing JSDoc documentation across all packages to comply with
the new linting rules.

Co-Authored-By: Claude <noreply@anthropic.com>
Update coverage thresholds based on actual test coverage after
dependency updates.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@sirtimid sirtimid requested a review from a team as a code owner January 12, 2026 19:28
@socket-security
Copy link

socket-security bot commented Jan 12, 2026

@socket-security
Copy link

socket-security bot commented Jan 12, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • deprecation@2.3.1
  • before-after-hook@2.2.3
  • @octokit/auth-token@4.0.0
  • universal-user-agent@6.0.1
  • @octokit/plugin-request-log@4.0.1
  • @octokit/endpoint@9.0.6
  • @octokit/request-error@5.1.1
  • @octokit/request@8.4.1
  • @octokit/graphql@7.1.1
  • @octokit/plugin-paginate-rest@11.4.4-cjs.2
  • @octokit/plugin-rest-endpoint-methods@13.3.2-cjs.1
  • @octokit/rest@20.1.2
  • @octokit/openapi-types@24.2.0
  • @octokit/types@13.10.0
  • @octokit/core@5.2.2
  • @metamask/approval-controller@8.0.0
  • @metamask/create-release-branch@4.1.3
  • @metamask/auto-changelog@5.3.0
  • @metamask/eslint-config-typescript@15.0.0
  • @metamask/eslint-config-nodejs@15.0.0
  • @metamask/eslint-config@15.0.0
  • @metamask/eslint-config-vitest@15.0.0
  • @metamask/snaps-registry@4.0.0
  • @metamask/utils@11.9.0
  • @metamask/snaps-sdk@10.3.0
  • @metamask/permission-controller@12.2.0
  • @metamask/controller-utils@11.18.0
  • @metamask/snaps-utils@11.7.1

View full report

@sirtimid
Copy link
Contributor Author

@SocketSecurity ignore-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants