chore: bump keyring API dependencies (Batch accounts 1/5)#608
Open
gantunesr wants to merge 3 commits into
Open
chore: bump keyring API dependencies (Batch accounts 1/5)#608gantunesr wants to merge 3 commits into
gantunesr wants to merge 3 commits into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8e8f32f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stack part 1 of 5 split from #601. This PR only bumps the keyring API dependencies needed for batch account creation and updates the lockfile. No behavior changes are intended.
Note
Medium Risk
Primarily dependency upgrades (major versions) for keyring/snaps packages, which could introduce breaking API or runtime behavior changes even though local code changes are mostly type/import adjustments.
Overview
Updates dependency versions to
@metamask/keyring-api@^22.0.0,@metamask/keyring-snap-sdk@^8.0.0, and pins@metamask/snaps-sdkto^11.0.0(plus lockfile updates), with changelog entries for site and snap.Refactors snap types so
CurrencyRateis defined inentities/currency.tsand consumers import it from local entities instead of@metamask/snaps-sdk, adjusting related imports in confirmation/send-flow/format and repositories/use-cases.Reviewed by Cursor Bugbot for commit 8f9336e. Bugbot is set up for automated code reviews on this repo. Configure here.