feat: wire keyring_createAccounts (Batch accounts 4/5)#611
Open
gantunesr wants to merge 1 commit into
Open
Conversation
keyring_createAccounts (Batch accounts 4/6)
keyring_createAccounts (Batch accounts 4/6)keyring_createAccounts (Batch accounts 4/5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack part 4 of 5 split from #601. Routes keyring_createAccounts, validates supported BIP-44 index/index-range options, chunks ranges internally in batches of 100, and maps responses back to KeyringAccount objects.
Note
Medium Risk
Introduces a new RPC pathway for batch account creation and adds input validation plus internal chunking logic, which could affect account provisioning behavior and ordering/trace handling if edge cases are missed.
Overview
Adds support for the
keyring_createAccountsRPC inKeyringHandler, validating that onlyBip44DeriveIndexandBip44DeriveIndexRangeare accepted and enforcing non-negative, inclusive index ranges.Implements batched account creation via
AccountUseCases.createMany, hard-coding v1 constraints (bitcoin mainnet + P2WPKH only), splitting requests into internal chunks of up to100, and wrapping the operation in snap tracing (Create Bitcoin Accounts Batch) withendTraceguaranteed infinally.Extends
KeyringHandler.test.tswith comprehensive coverage for range handling, ordering, batching behavior, unsupported types, address-type constraints, error propagation, and tracing; adds a smallexpectDefinedhelper for type narrowing in tests.Reviewed by Cursor Bugbot for commit c10b933. Bugbot is set up for automated code reviews on this repo. Configure here.