refactor: cache account response metadata (Batch accounts 5/5)#612
Open
gantunesr wants to merge 1 commit into
Open
refactor: cache account response metadata (Batch accounts 5/5)#612gantunesr wants to merge 1 commit into
gantunesr wants to merge 1 commit into
Conversation
gantunesr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack part 5 of 5 split from #601. Adds cached account metadata and StoredAccountAdapter so keyring-response-oriented lookups can avoid loading full BDK wallets when metadata is present.
Note
Medium Risk
Introduces a new lightweight account-loading path based on persisted metadata, which could cause runtime errors if callers assume full wallet capabilities from repository lookups.
Overview
Adds optional persisted
AccountMetadata(address,addressType,network,publicDescriptor) toAccountStateand stores it whenever accounts are inserted.Introduces
StoredAccountAdapter, a metadata-onlyBitcoinAccountimplementation that supports keyring-oriented fields but throws on wallet operations, and updatesBdkAccountRepository.getByDerivationPathsto prefer this adapter when metadata is present (avoidingChangeSet/BDK wallet loading). Tests are updated to validate the cached-metadata path and new persistence fields.Reviewed by Cursor Bugbot for commit 5319470. Bugbot is set up for automated code reviews on this repo. Configure here.