Add opt-in Nishvault pre-send receipt before XMTP 402 payment broadcast - #15
Open
cakirasim wants to merge 1 commit into
Open
Add opt-in Nishvault pre-send receipt before XMTP 402 payment broadcast#15cakirasim wants to merge 1 commit into
cakirasim wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an opt-in guard immediately before the existing USDC transfer broadcast in
src/chain/xmtp402.ts.When
NISHVAULT_PRE_SEND_GUARD=1is set, the payment flow becomes:Default behavior is unchanged because the guard is disabled unless the env var is set.
Configuration:
Why this fits this repo:
xmtp402.tsalready has the exact broadcast slot.npx --package nishvault-preflight-buy nishvault-guard-txonly when explicitly enabled.Validation:
Note: the full repo typecheck currently fails on existing unrelated missing modules/config typing errors. A targeted
tscinvocation forsrc/chain/xmtp402.tsreaches only existingsrc/config.tsstrictness errors and does not report errors from the Nishvault patch.