Add check fo report and observations #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cghielmini
force-pushed
the
improve_probtest_v2
branch
from
1d43ff0 to
95c44d2
Compare
huppd
reviewed
Dec 19, 2025
Collaborator
huppd
left a comment
huppd
left a comment
There was a problem hiding this comment.
Thanks for the nice improvements. I have some small suggestions, some of the have slipt previous reviews 🙃
clairemerker
reviewed
Jan 5, 2026
clairemerker
reviewed
Jan 6, 2026
clairemerker
left a comment
clairemerker
left a comment
There was a problem hiding this comment.
Really nice to now be able to test all variables :) Thanks a lot!
I have added some comments, we can also discuss some of my suggestions since I am not sure I understood the code everywhere!
huppd
reviewed
Jan 7, 2026
huppd
reviewed
Jan 7, 2026
clairemerker
approved these changes
Jan 8, 2026
huppd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the previous version of probtest is modified to ensure that all values in reports and observations are compared.