Feat/session#152
Merged
Merged
Conversation
|
@nafiuishaaq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented session-bound auth hardening in auth.service.ts, jwt-auth.guard.ts, and auth.controller.ts. Access and refresh tokens now carry a session ID, each session is persisted in Redis with fingerprint, last activity, idle timeout, and absolute expiry, and every authenticated request validates that the token still belongs to an active matching session before proceeding.
This also adds the timeout and fixation protections the ticket asked for: idle sessions now expire based on lastActivity, sessions have an absolute lifetime, and login/refresh rotate the session state instead of reusing the old one. That blocks session fixation and makes replayed tokens fail when the fingerprint or bound session no longer matches. I updated the token/session Redis key model in constants.ts and extended the auth tests in auth.service.spec.ts to cover refresh-session binding and fingerprint mismatch rejection.
Closes #100