Repository navigation
Fix PAM-first audit log ownership - #9
Merged
Merged
Conversation
This was referenced Nov 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sudo invokes PAM before the user daemon starts, PAM creates last.log as root and the daemon cannot append transaction records. Create new audit files with mode 0600 and assign their file descriptor the bond-store directory's owner/group before writing. Preserve existing files and reject final-component symlinks.
Regression coverage checks private creation, symlink rejection, ownership under root-run PAM, and preservation of previous records. CI explicitly runs the privileged ownership test against a disposable tempdir; no live PAM stack is touched.
Validation: make lint; make test (461 passed, 11 ignored); privileged ownership regression passed in an isolated rootless container. The original failure was reproduced in the NixOS KVM review of #7; the combined Nix changes will receive the full VM rerun after this fix merges.
Existing root-owned audit files retain their ownership; documented administrator recovery preserves their contents.