Skip to content

modified code for batch inference#31

Open
iamrishab wants to merge 2 commits into
MhLiao:masterfrom
iamrishab:master
Open

modified code for batch inference#31
iamrishab wants to merge 2 commits into
MhLiao:masterfrom
iamrishab:master

Conversation

@iamrishab

Copy link
Copy Markdown

@MhLiao

MhLiao commented Nov 21, 2019

Copy link
Copy Markdown
Owner

Thanks for your contribution! I am checking the pull request. It seems that you modified the indentations so it is hard to see the actual changes of the code since most of the lines are labeled as differences.

@iamrishab

Copy link
Copy Markdown
Author

Thanks for your feedback. I will fix the indentation and create a new pull request.

@MhLiao

MhLiao commented Nov 23, 2019

Copy link
Copy Markdown
Owner

@iamrishab It seems that the char maps are wrongly localized with the current PR.

@iamrishab

Copy link
Copy Markdown
Author

@MhLiao
Hi! I have already tested the code and it's able localize the char maps correctly

@iamrishab

Copy link
Copy Markdown
Author

@MhLiao will you be able to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants