update form and to do list#2
Open
MichaelGarbuzov wants to merge 5 commits into
Open
Conversation
Tamir198
reviewed
Jan 11, 2023
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
Consider using css variables for repeating values (if you want to change some value you will have to change it in all the places the color is used).
Please be consistent with your component name.
for example, change form.js to Form.js
Improvement idea - don't let your user add empty TODO.
| export const ThemeContext = createContext("null"); | ||
|
|
||
| function App() { | ||
| const [inputText, setInputText] = useState(""); |
There was a problem hiding this comment.
Do you really need this state? you are only using it to set the value in the form to be "". Why not init the form value to "" ?
|
|
||
| function App() { | ||
| const [inputText, setInputText] = useState(""); | ||
| const [todos, setTodos] = useState([]); |
There was a problem hiding this comment.
Cant this state sit inside ToDoList.js ? Do you need it inside App.js
|
|
||
| const Form = ({ setInputText, todos, setTodos, inputText }) => { | ||
| const inputTextHandler = (e) => { | ||
| console.log(e.target.value); |
There was a problem hiding this comment.
Please don't leave non used comments and prints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.