fix: mask PSST_PASSWORD in child process output - #41
Open
master085358 wants to merge 2 commits into
Open
master085358 wants to merge 2 commits into
master085358 wants to merge 2 commits into
Conversation
added 2 commits
September 8, 2026 09:35
…ntials file) Hybrid of duanddqn/psst sqlite-keystore approach with stricter security: - keystore.db stores vault key encrypted with PBKDF2(100k) + AES-256-GCM - Password must come from PSST_PASSWORD env var — never persisted to disk - No ~/.psst/credentials file (unlike upstream fork) - New command: psst passwd (change keystore password via env vars) - config.json records keyBackend: sqlite for vault discovery
master085358
force-pushed
the
fix/mask-psst-password
branch
from
September 8, 2026 08:22
a26018d to
711d9b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
PSST_PASSWORDis set (keychain fallback), runningpsst run echo $PSST_PASSWORDprints the master password in plaintext. The shell expands
$PSST_PASSWORDbefore psstsees the argument, and since the vault may be empty (no secrets to mask), the value
passes through unmasked.
Fix
Always add
PSST_PASSWORDto the masking list in bothexec.tsandrun.ts,regardless of whether the vault contains secrets.
Testing