Skip to content
This repository was archived by the owner on Sep 11, 2026. It is now read-only.

Drop the offline-save/file:// claim from published copy - #11

Merged
MichalAFerber merged 1 commit into
mainfrom
dave/drop-offline-save-claim
Sep 10, 2026
Merged

MichalAFerber merged 1 commit into
mainfrom
dave/drop-offline-save-claim

Conversation

@tgwab-claude

@tgwab-claude tgwab-claude commented Sep 10, 2026 •

Copy link
Copy Markdown
Collaborator

Why

While comparing this repo against its wizard-web Astro port before adding it to wizard-web's deploy matrix, I found the port had silently dropped the claim that you can save the whole app locally and run it from a file:// copy. I checked rather than assumed the omission was a regression: Astro emits root-absolute /_astro/... asset paths, so a saved copy of the Astro build's CSS/JS 404s under file:// — the claim would be false the moment wizard-web takes over serving markdownwizard.app.

Michal's ruling on that finding: drop the offline-save feature from the site, rather than port the claim or fix the Astro app's asset paths to make it true there.

What

This repo's own copy still makes the claim today and stays the live text people read until the wizard-web cutover PR lands, so it comes out here too rather than waiting for the swap to silently retire it:

  • docs.html "Working offline": dropped the save-locally sentence. Kept "the editor keeps working after the page has loaded, with no network connection" — still true, and a distinct claim from saving/reopening a copy.
  • privacy.html "Your document": reworded the "still available offline" bullet to the same narrower, still-true claim. Dropped the sentence about Plausible not loading when opened from a saved file:// copy — it describes a workflow no longer being advertised.

Deliberately not touched: js/analytics.js's file:-protocol guard and tests/e2e.mjs's "file:// operation" suite. The underlying capability isn't being disabled today, isn't broken, and the guard is harmless defensive code either way — only the published promise that this is a supported way to use the product is being retired.

Naming this so it doesn't come back: someone diffing old vs. new copy in six months could reasonably assume the offline-save section was lost in the wizard-web migration, the same way the troubleshooting section actually was (wizard-web#118). It wasn't lost — it was deliberately cut, for the /_astro/ reason above. This PR body and commit message are the record.

Verification

  • node tests/e2e.mjs — all checks pass, including "file:// operation (offline / double-click use)", unaffected since the capability itself is untouched.
  • node tests/csp-check.mjs — clean, no CSP violations.

Not related to the deploy-matrix cutover

This is a copy fix only. It does not touch .github/workflows/deploy.yml — the standalone repo keeps deploying as-is until the separate matrix-cutover PR pair (wizard-web#117, #118, and the still-to-come matrix-addition + standalone-deploy-disable pair) lands.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EQYeUULNUFx2m5nm6fCLwj

Michal's ruling: drop the offline-save feature from the site rather than
port it to the wizard-web Astro app or fix the app's asset paths to make
it true there. Astro emits root-absolute /_astro/... paths, so a saved
copy's CSS/JS 404s under file:// — the claim would be false the moment
wizard-web takes over serving markdownwizard.app.

This repo's own copy still makes the claim, and it stays the live text
until the cutover PR lands, so it comes out here too rather than waiting
for the swap to silently retire it:

- docs.html "Working offline": dropped the save-locally sentence, kept
  "the editor keeps working after the page has loaded, with no network
  connection" (still true, and distinct from the save/reopen claim).
- privacy.html "Your document": reworded the "still available offline"
  bullet to the same narrower, still-true claim; dropped the sentence
  about Plausible not loading when opened from a saved file:// copy,
  since that describes a workflow no longer being advertised.

Deliberately NOT touched: js/analytics.js's file://-protocol guard and
tests/e2e.mjs's "file:// operation" suite. The underlying capability
still works today and isn't being disabled — only the published promise
that it's a supported way to use the product is being retired. Both
still pass (`node tests/e2e.mjs`, `node tests/csp-check.mjs`).

Filed so a future reader diffing old vs. new copy finds this commit
instead of assuming the offline-save section was lost in the wizard-web
migration, the way the troubleshooting section actually was (see
wizard-web#118).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EQYeUULNUFx2m5nm6fCLwj
@MichalAFerber MichalAFerber self-assigned this Sep 10, 2026
@MichalAFerber
MichalAFerber marked this pull request as ready for review September 10, 2026 05:53
@MichalAFerber
MichalAFerber enabled auto-merge (squash) September 10, 2026 05:53
@MichalAFerber
MichalAFerber merged commit 0eacf7e into main Sep 10, 2026
2 checks passed
@MichalAFerber
MichalAFerber deleted the dave/drop-offline-save-claim branch September 10, 2026 06:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants