fix: correct the xss-fixture ignore comment (DS §15 trap 9) - #5
Merged
Merged
Conversation
The rename does not make the test go green with zero findings — it swallows the fixture and both assertions go red. Re-vendored from tgwab-standards templates/eslint.config.js after #131. Refs MichalAFerber/tgwab-standards#132 Fleet: grok Agent: grok Ticket: MichalAFerber/tgwab-standards#132
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YCuqgLNmW73GV8ocz7XTLQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft. Re-vendor of the
eslint.configignore comment after tgwab-standards#131.The comment claimed renaming
src/__xss-lint-fixture__.jstosrc/xss-lint-fixture.jsmakes the test go green with zero findings. Measured in the template (eslint@10.10.0): the renamed path reports 0 findings and both assertions go red. The test fails loudly; it does not pass.This PR replaces that paragraph with the corrected text from
tgwab-standards/templates/eslint.config.jsonorigin/main. No rule, ignore glob, or other config change.Refs MichalAFerber/tgwab-standards#132
Fleet: grok
Agent: grok
Ticket: MichalAFerber/tgwab-standards#132
Draft per the gate: DevOps marks ready, Michal merges. I will not merge this.