ci: move the pinned Go toolchain to 1.26.x - #11
Merged
Merged
Conversation
Dependabot #10 bumps golang.org/x/sys 0.47.0 -> 0.48.0, which requires Go 1.26, so `go mod tidy` also raised go.mod's go directive from 1.25.0 to 1.26.0. Both workflows pin go-version "1.25.x", and a 1.25 toolchain refuses to build a module declaring go 1.26.0 — #10's Logic tests fail in 8s on macOS and 21s on Ubuntu. Dependabot only edits go.mod and go.sum, so it cannot fix this itself. release.yml is bumped alongside ci.yml deliberately. It pins the same 1.25.x but is not exercised by pull_request, so fixing only ci.yml would make #10 go green while leaving the release build broken — discovered later, by whoever next cuts a tag. That is a worse failure than this one because it is delayed and silent. A 1.26 toolchain still builds the current go 1.25.0 module, so this can merge before #10 and is safe on its own. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EQYeUULNUFx2m5nm6fCLwj
MichalAFerber
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks Dependabot #10, and fixes a second breakage that #10 would have hidden.
Why #10 fails
#10 is titled as a
golang.org/x/sys0.47.0 → 0.48.0 bump, but the diff does more than that:x/sysv0.48.0 requires Go 1.26, sogo mod tidyraised the module's owngodirective. Both workflows pingo-version: "1.25.x", and a 1.25 toolchain refuses to build a module declaringgo 1.26.0. That is the whole failure — Logic tests died in 8s on macOS and 21s on Ubuntu, far too fast to be a test assertion.Dependabot only edits
go.modandgo.sum, so it cannot repair this itself. The toolchain pin has to move in a separate change.Why
release.ymlis in this PR toorelease.ymlpins the same1.25.x, but its triggers do not includepull_request— it runs on a tag push. So fixing onlyci.ymlwould turn #10 green while leaving the release build broken, and nobody would find out until the next tag was cut.That is a worse failure than the visible one: delayed, silent, and discovered at exactly the moment you want a release. v2.0.0 was built on 1.25.x this morning, so the next tag is the first one that would hit it.
Verified there are no residual
1.25references anywhere under.github/workflows/.Order
This can merge before #10 and is safe standing alone — a 1.26 toolchain still builds the current
go 1.25.0module. Once this lands, re-run #10 and it should pass.Verified
grep -rn "1\.25" .github/workflows/returns nothing.Not verified
🤖 Generated with Claude Code
https://claude.ai/code/session_01EQYeUULNUFx2m5nm6fCLwj