Bugfix/undefined returned by some api methods - #1
Open
GearoidSugrue wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks for the PR! I'll check it and functionally test it soon. |
Author
|
Hey, have you had a chance to look at this? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Firstly thanks for this node module, its great! Especially all the Types and Interfaces, it saved me a lot of time :)
I've found a few small issues and would like to help fix.
The first one is that NS v3 responses are different from the v2 ones. They don't follow the same response pattern of:
Instead, they just return the data. For example, GET
/tripsresponse is:It's an simple fix. Just
resolve(message)instead ofresolve(message.payload)ingetTripandgetTripsinapi.ts.Most of the other changes were to fix the Typescript errors it caused. I hope my solution is ok? Feel free to make recommendations!
Also, I had to upgrade typescript. It was failing to build because of the comments in the tsconfig.json file.
As I mentioned, there are a few other minor issues. I'll create separate issues for them.