Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new GitHub Actions CI workflow file to automate build and lint jobs on multiple operating systems.
- Implements build steps including checkout, Node.js setup, Rust installation, Gleam setup, and building both frontend and a Tauri app.
- Adds a lint job on Ubuntu that verifies TypeScript and Rust formatting and errors.
Comment on lines
+32
to
+42
| if: matrix.platform != 'windows-latest' | ||
|
|
||
| - name: Install Gleam (Windows) | ||
| run: | | ||
| iwr https://github.com/gleam-lang/gleam/releases/download/v0.32.0/gleam-v0.32.0-windows-x86_64.zip -OutFile gleam.zip | ||
| Expand-Archive -Path gleam.zip -DestinationPath . | ||
| Move-Item -Path .\gleam.exe -Destination $env:USERPROFILE\.cargo\bin\gleam.exe | ||
| if: matrix.platform == 'windows-latest' | ||
|
|
||
| - name: Install dependencies (ubuntu only) | ||
| if: matrix.platform == 'ubuntu-20.04' |
There was a problem hiding this comment.
Consider wrapping the conditional expression in ${{ }} for improved clarity and consistency (e.g., if: ${{ matrix.platform != 'windows-latest' }}).
Suggested change
| if: matrix.platform != 'windows-latest' | |
| - name: Install Gleam (Windows) | |
| run: | | |
| iwr https://github.com/gleam-lang/gleam/releases/download/v0.32.0/gleam-v0.32.0-windows-x86_64.zip -OutFile gleam.zip | |
| Expand-Archive -Path gleam.zip -DestinationPath . | |
| Move-Item -Path .\gleam.exe -Destination $env:USERPROFILE\.cargo\bin\gleam.exe | |
| if: matrix.platform == 'windows-latest' | |
| - name: Install dependencies (ubuntu only) | |
| if: matrix.platform == 'ubuntu-20.04' | |
| if: ${{ matrix.platform != 'windows-latest' }} | |
| - name: Install Gleam (Windows) | |
| run: | | |
| iwr https://github.com/gleam-lang/gleam/releases/download/v0.32.0/gleam-v0.32.0-windows-x86_64.zip -OutFile gleam.zip | |
| Expand-Archive -Path gleam.zip -DestinationPath . | |
| Move-Item -Path .\gleam.exe -Destination $env:USERPROFILE\.cargo\bin\gleam.exe | |
| if: ${{ matrix.platform == 'windows-latest' }} | |
| - name: Install dependencies (ubuntu only) | |
| if: ${{ matrix.platform == 'ubuntu-20.04' }} |
Comment on lines
+32
to
+42
| if: matrix.platform != 'windows-latest' | ||
|
|
||
| - name: Install Gleam (Windows) | ||
| run: | | ||
| iwr https://github.com/gleam-lang/gleam/releases/download/v0.32.0/gleam-v0.32.0-windows-x86_64.zip -OutFile gleam.zip | ||
| Expand-Archive -Path gleam.zip -DestinationPath . | ||
| Move-Item -Path .\gleam.exe -Destination $env:USERPROFILE\.cargo\bin\gleam.exe | ||
| if: matrix.platform == 'windows-latest' | ||
|
|
||
| - name: Install dependencies (ubuntu only) | ||
| if: matrix.platform == 'ubuntu-20.04' |
There was a problem hiding this comment.
Consider using ${{ }} to wrap the conditional expression for consistency with GitHub Actions recommendations (e.g., if: ${{ matrix.platform == 'windows-latest' }}).
Suggested change
| if: matrix.platform != 'windows-latest' | |
| - name: Install Gleam (Windows) | |
| run: | | |
| iwr https://github.com/gleam-lang/gleam/releases/download/v0.32.0/gleam-v0.32.0-windows-x86_64.zip -OutFile gleam.zip | |
| Expand-Archive -Path gleam.zip -DestinationPath . | |
| Move-Item -Path .\gleam.exe -Destination $env:USERPROFILE\.cargo\bin\gleam.exe | |
| if: matrix.platform == 'windows-latest' | |
| - name: Install dependencies (ubuntu only) | |
| if: matrix.platform == 'ubuntu-20.04' | |
| if: ${{ matrix.platform != 'windows-latest' }} | |
| - name: Install Gleam (Windows) | |
| run: | | |
| iwr https://github.com/gleam-lang/gleam/releases/download/v0.32.0/gleam-v0.32.0-windows-x86_64.zip -OutFile gleam.zip | |
| Expand-Archive -Path gleam.zip -DestinationPath . | |
| Move-Item -Path .\gleam.exe -Destination $env:USERPROFILE\.cargo\bin\gleam.exe | |
| if: ${{ matrix.platform == 'windows-latest' }} | |
| - name: Install dependencies (ubuntu only) | |
| if: ${{ matrix.platform == 'ubuntu-20.04' }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.