Merged
Conversation
Feature/workflow update
…lopment). Also: * Updated tests to handle `children` change * Added `util.flatiter()` function (was planned for later, but needed for tests) * Updated tool tests to run only in GitHub Actions (does not work locally if package not installed)
Converted `children` from a `dict` to a `set` of IDs
# Conflicts: # ebmlite/core.py # ebmlite/util.py
Annotation and docstring edits
* Updated Python versions in setup and unit tests; removed special-casing for Python<3.9; setup reads `__version__ ` from `__init__.py` * Updated GHA versions * Attempting to fix `upload-artifact` conflict * Removed flake8 check (fails in Python 3.12+) * Removed `upload-artifact` (we don't use it in other repos) * Removed importlib python < 3.9 special case
* Added basic Sphinx docs (some from ancient branch, needs updating) * Set up theme (mostly) * more docs * Removed redundant readme * Added doc requirements * Adding read the docs file recommended by readthedocs (#132) --------- Co-authored-by: Peter Scheidler <pscheidler@gmail.com>
(cherry picked from commit 2290633)
Co-authored-by: MIDE\cflanigan <cflanigan@mide.com>
Supporting path objects for filenames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most significant change in this version is documentation, which is now automatically generated and served by readthedocs: https://mide-technology-endaq-docs.readthedocs-hosted.com/projects/ebmlite/en/latest/
Functional changes:
util.flatiter()function, which recursively crawls aDocument/MasterElementyielding elements (same concept asnumpy.flatiter()).MasterElement.children(the container's valid child element classes) changed from a dictionary (of classes keyed by ID) to a set of IDs. This will only affect code that directly references the attribute (a somewhat obscure edge case).nameandidattributes explicitly added toElement, fixing some 'unknown attribute' linter warnings.