Repository navigation
β‘ Bolt: Replace Math.max with reduce - #855
Mihir-Rabari wants to merge 2 commits into
Conversation
Co-authored-by: Mihir-Rabari <169349389+Mihir-Rabari@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: Mihir-Rabari <169349389+Mihir-Rabari@users.noreply.github.com>
π‘ What: Replaced usages of Math.max(...array) and Math.max(...array.map) with a single .reduce() pass.
π― Why: Math.max with the spread operator can cause O(N) intermediate array allocations and spread operator overhead, leading to Maximum call stack size exceeded errors with large arrays.
π Impact: Eliminates intermediate array allocations and prevents potential call stack errors for large datasets, improving performance and reliability.
π¬ Measurement: Verify tests and builds pass, and dashboard charts render correctly.
PR created automatically by Jules for task 11823848409765173224 started by @Mihir-Rabari