Repository navigation
⚡ Bolt: Replace Math.max with reduce - #858
Mihir-Rabari wants to merge 3 commits into
Conversation
Replaces usages of `Math.max(...array)` and `Math.max(...array.map(fn))` with a single `.reduce()` pass in dashboard components. This avoids O(N) intermediate array allocations and spread operator overhead during React renders, preventing "Maximum call stack size exceeded" errors with large arrays. Co-authored-by: Mihir-Rabari <169349389+Mihir-Rabari@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Replaces usages of `Math.max(...array)` and `Math.max(...array.map(fn))` with a single `.reduce()` pass in dashboard components. This avoids O(N) intermediate array allocations and spread operator overhead during React renders, preventing "Maximum call stack size exceeded" errors with large arrays. Co-authored-by: Mihir-Rabari <169349389+Mihir-Rabari@users.noreply.github.com>
The `RoutingService.test.ts` was failing because the fallback configuration (4th argument) was not being provided, causing the service to attempt fetching defaults from the environment and failing the exact `0` providers assertion. Additionally, records the learning that we should not try to fix workspace-wide package.json test scripts when resolving CI failures. Co-authored-by: Mihir-Rabari <169349389+Mihir-Rabari@users.noreply.github.com>
💡 What: Replaced usages of
Math.max(...array)andMath.max(...array.map(fn))with a single.reduce()pass in dashboard components.🎯 Why: Avoids O(N) intermediate array allocations and spread operator overhead during React renders, preventing "Maximum call stack size exceeded" errors with large arrays.
📊 Impact: Reduces memory allocation per render cycle and improves rendering speed for large datasets.
🔬 Measurement: Observe dashboard rendering performance and memory usage in browser devtools.
PR created automatically by Jules for task 8670270375052709776 started by @Mihir-Rabari